r96360 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96359‎ | r96360 | r96361 >
Date:19:11, 6 September 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: MFT r96180, r96228, r96273, r96286
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/CentralNotice/CentralNotice.php (modified) (history)
  • /branches/wmf/1.17wmf1/extensions/Collection/Collection.body.php (modified) (history)
  • /branches/wmf/1.17wmf1/includes/Title.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/Collection/Collection.body.php
@@ -956,7 +956,7 @@
957957
958958 $response = self::mwServeCommand( 'render', array(
959959 'metabook' => $this->buildJSONCollection( $collection ),
960 - 'base_url' => wfExpandUrl( $wgScriptPath, PROTO_CANONICAL ),
 960+ 'base_url' => wfExpandUrl( $wgScriptPath, PROTO_CURRENT ),
961961 'script_extension' => $wgScriptExtension,
962962 'template_blacklist' => wfMsgForContent( 'coll-template_blacklist_title' ),
963963 'template_exclusion_category' => wfMsgForContent( 'coll-exclusion_category_title' ),
@@ -989,7 +989,7 @@
990990
991991 $response = self::mwServeCommand( 'render', array(
992992 'collection_id' => $collectionID,
993 - 'base_url' => wfExpandUrl( $wgScriptPath, PROTO_CANONICAL ),
 993+ 'base_url' => wfExpandUrl( $wgScriptPath, PROTO_CURRENT ),
994994 'script_extension' => $wgScriptExtension,
995995 'template_blacklist' => wfMsgForContent( 'coll-template_blacklist_title' ),
996996 'template_exclusion_category' => wfMsgForContent( 'coll-exclusion_category_title' ),
@@ -1161,7 +1161,7 @@
11621162
11631163 $response = self::mwServeCommand( 'zip_post', array(
11641164 'metabook' => $this->buildJSONCollection( $collection ),
1165 - 'base_url' => wfExpandUrl( $wgScriptPath, PROTO_CANONICAL ),
 1165+ 'base_url' => wfExpandUrl( $wgScriptPath, PROTO_CURRENT ),
11661166 'script_extension' => $wgScriptExtension,
11671167 'template_blacklist' => wfMsgForContent( 'coll-template_blacklist_title' ),
11681168 'template_exclusion_category' => wfMsgForContent( 'coll-exclusion_category_title' ),
Index: branches/wmf/1.17wmf1/extensions/CentralNotice/CentralNotice.php
@@ -191,7 +191,7 @@
192192
193193 function efCentralNoticeGeoLoader( $skin, &$text ) {
194194 // Insert the geo IP lookup
195 - $text .= '<script type="text/javascript" src="http://geoiplookup.wikimedia.org/"></script>';
 195+ $text .= '<script type="text/javascript" src="//geoiplookup.wikimedia.org/"></script>';
196196 return true;
197197 }
198198
Property changes on: branches/wmf/1.17wmf1/extensions/CentralNotice/CentralNotice.php
___________________________________________________________________
Modified: svn:mergeinfo
199199 Merged /trunk/extensions/CentralNotice/CentralNotice.php:r96180,96228,96273,96286
200200 Merged /trunk/phase3/extensions/CentralNotice/CentralNotice.php:r96180,96228,96273,96286
Index: branches/wmf/1.17wmf1/includes/Title.php
@@ -840,7 +840,7 @@
841841 # Finally, add the fragment.
842842 $url .= $this->getFragmentForURL();
843843
844 - wfRunHooks( 'GetFullURL', array( &$this, &$url, $query ) );
 844+ wfRunHooks( 'GetFullURL', array( &$this, &$url, $query, $variant ) );
845845 return $url;
846846 }
847847
@@ -999,7 +999,7 @@
10001000 global $wgInternalServer, $wgServer;
10011001 $server = $wgInternalServer !== false ? $wgInternalServer : $wgServer;
10021002 $url = wfExpandUrl( $server . $this->getLocalURL( $query, $variant ), PROTO_HTTP );
1003 - wfRunHooks( 'GetInternalURL', array( &$this, &$url, $query ) );
 1003+ wfRunHooks( 'GetInternalURL', array( &$this, &$url, $query, $variant ) );
10041004 return $url;
10051005 }
10061006
@@ -1016,8 +1016,8 @@
10171017 */
10181018 public function getCanonicalURL( $query = '', $variant = false ) {
10191019 global $wgCanonicalServer;
1020 - $url = $wgCanonicalServer . $this->getLocalURL( $query, $variant ) . $this->getFragmentForURL();
1021 - wfRunHooks( 'GetCanonicalURL', array( &$this, &$url, $query ) );
 1020+ $url = wfExpandUrl( $this->getLocalURL( $query, $variant ) . $this->getFragmentForURL(), PROTO_CANONICAL );
 1021+ wfRunHooks( 'GetCanonicalURL', array( &$this, &$url, $query, $variant ) );
10221022 return $url;
10231023 }
10241024
Property changes on: branches/wmf/1.17wmf1/includes/Title.php
___________________________________________________________________
Modified: svn:mergeinfo
10251025 Merged /trunk/phase3/includes/Title.php:r96180,96228,96273,96286

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96180Use wfExpandUrl+PROTO_CANONICAL inside of getCanonicalURL instead of just pre...dantman13:17, 3 September 2011
r96228(bug 30735) Use protocol-relative URL for geoiplookup. Should not be deployed...catrope14:28, 4 September 2011
r96273Followup r96180, I can't believe I did't notice I accidentally killed the hoo...dantman08:31, 5 September 2011
r96286Fix r95653: as reported on bug 30680, this broke Collection. Expanding $wgScr...catrope16:06, 5 September 2011

Status & tagging log