r95614 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95613‎ | r95614 | r95615 >
Date:02:59, 28 August 2011
Author:johnduhart
Status:ok (Comments)
Tags:
Comment:
Adds link to path history in modified paths section
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -92,6 +92,7 @@
9393 'code-rev-purge-link' => 'purge',
9494 'code-rev-total' => 'Total number of results: $1',
9595 'code-rev-not-found' => "Revision '''$1''' does not exist!",
 96+ 'code-rev-history-link' => 'history',
9697 'code-status-new' => 'new',
9798 'code-status-desc-new' => 'Revision is pending an action (default status).',
9899 'code-status-fixme' => 'fixme',
Index: trunk/extensions/CodeReview/ui/CodeRevisionView.php
@@ -291,6 +291,10 @@
292292 $path = preg_replace( '/ \([^\)]+\)$/', '', $path );
293293 $viewvc = $this->mRepo->getViewVcBase();
294294 $diff = '';
 295+ $hist = $this->skin->link(
 296+ SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() ),
 297+ wfMsg( 'code-rev-history-link' ), array(), array( 'path' => $path )
 298+ );
295299 $safePath = wfUrlEncode( $path );
296300 if ( $viewvc ) {
297301 $rev = $this->mRev->getId();
@@ -318,7 +322,7 @@
319323 } else {
320324 $link = $safePath;
321325 }
322 - return "<li><b>$link</b> ($desc)$diff</li>\n";
 326+ return "<li><b>$link</b> ($desc) ($hist)$diff</li>\n";
323327 }
324328
325329 protected function tagForm() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r108623MFT r95614, r104865, r105908, r107050reedy15:16, 11 January 2012

Comments

#Comment by Johnduhart (talk | contribs)   18:36, 7 January 2012

Would really like to have this live.

Status & tagging log