r107050 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107049‎ | r107050 | r107051 >
Date:09:56, 22 December 2011
Author:siebrand
Status:ok (Comments)
Tags:
Comment:
Add gender support for two messages.

Uncertain yet if this is properly done in the code. From ApiViewFeedbackArticleFeedbackv5.php:

$found = wfMessage(
'articlefeedbackv5-form1-header-found',
$name
)->escaped();
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -53,8 +53,8 @@
5454 'articlefeedbackv5-form-hide' => 'Hide this ($1)',
5555 'articlefeedbackv5-form-abuse' => 'Flag as abuse ($1)',
5656 'articlefeedbackv5-form-header' => 'Feedback #$1, at $2',
57 - 'articlefeedbackv5-form1-header-found' => '$1 found what they were looking for:',
58 - 'articlefeedbackv5-form1-header-not-found' => '$1 did not find what they were looking for:',
 57+ 'articlefeedbackv5-form1-header-found' => '{{GENDER:$1|$1}} found what they were looking for:',
 58+ 'articlefeedbackv5-form1-header-not-found' => '{{GENDER:$1|$1}} did not find what they were looking for:',
5959 'articlefeedbackv5-form2-header' => '$1 had a $2:',
6060 'articlefeedbackv5-form3-header' => '$1 rated this page $2/5',
6161 'articlefeedbackv5-form4-header' => 'User was presented with the CTA-only form.',

Follow-up revisions

RevisionCommit summaryAuthorDate
r108623MFT r95614, r104865, r105908, r107050reedy15:16, 11 January 2012

Comments

#Comment by Nikerabbit (talk | contribs)   10:28, 22 December 2011

It's usually around the verb, but I see no reason why it wouldn't work.

Status & tagging log