r95340 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r95339‎ | r95340 | r95341 >
Date:21:52, 23 August 2011
Author:brion
Status:reverted (Comments)
Tags:
Comment:
* (bug 30485) Fixed interference between wikihiero extension and 'wikitable' class style

Border & padding settings from the .wikitable class were overriding the rules for .mw-hiero-table and .mw-hiero-table td. Added !important on them to make sure that those inner styles consistently override whatever generic table cell rules might be in play that have the same or greater specificity.
Long-term of course it might be nice to rewrite the whole thing to compose SVG and output that. :)
Modified paths:
  • /trunk/extensions/wikihiero/modules/ext.wikihiero.css (modified) (history)

Diff [purge]

Index: trunk/extensions/wikihiero/modules/ext.wikihiero.css
——@@ -1,6 +1,6 @@
22 .mw-hiero-table {
3 - border: 0;
4 - border-spacing: 0;
 3+ border: 0 !important;
 4+ border-spacing: 0 !important;
55 }
66
77 .mw-hiero-outer {
——@@ -8,7 +8,8 @@
99 }
1010
1111 .mw-hiero-table td {
12 - padding: 0;
13 - align: center;
14 - vertical-align: middle;
 12+ border: 0 !important;
 13+ padding: 0 !important;
 14+ text-align: center !important;
 15+ vertical-align: middle !important;
1516 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r96474Backport r95340, partial r94773 from trunk for bug 30485: set override styles...brion19:22, 7 September 2011
r96477Backport r95340, partial r94773 from trunk for bug 30485: set override styles...brion19:43, 7 September 2011
r96481Merge r96474 from 1.17 -- Backport r95340, partial r94773 from trunk for bug ......brion19:51, 7 September 2011
r107669* more specific selectors for wikitable - don't inherit properties to nested ...danny_b23:23, 30 December 2011
r107671* Reverting r95340 in favour of r107669danny_b23:27, 30 December 2011

Comments

#Comment by Hashar (talk | contribs)   15:28, 28 August 2011

There is no 'modules' in 1.18 :p

#Comment by Brion VIBBER (talk | contribs)   18:23, 29 August 2011

Presumably there's a pre-resourceloader version of the file with a different path?

#Comment by MaxSem (talk | contribs)   18:43, 29 August 2011

No, previously it emitted all styles inline:P

#Comment by Brion VIBBER (talk | contribs)   18:46, 29 August 2011

Then that should be findable in the .php files for backporting.

#Comment by Catrope (talk | contribs)   18:22, 7 September 2011

This is unmergeable in 1.17wmf1, the relevant CSS is nowhere to be found. Untagging 1.17wmf1; if you want this fix deployed, please write a patch against 1.17wmf1 yourself.

#Comment by Brion VIBBER (talk | contribs)   19:54, 7 September 2011

Backported:

This adds the .css file & tweaks it to point at the older class name; the inline CSS is still left as-is (harmless).

Merging in the whole refactored extension later might be nice, but no rush.

Status & tagging log