r95341 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r95340‎ | r95341 | r95342 >
Date:22:03, 23 August 2011
Author:wikinaut
Status:resolved (Comments)
Tags:
Comment:
test case for jquery.highlightText.js : test case 025a => fails
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/jquery/jquery.highlightText.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/jquery/jquery.highlightText.test.js
——@@ -158,6 +158,12 @@
159159 expected: '<span class="highlight">«</span> <span class="highlight">L\'oise</span>au est sur l’île »'
160160 },
161161 {
 162+ desc: 'Test 025a: fr French text and « french quotes » (guillemets) (fails)',
 163+ text: "« L'oiseau est sur l’île »",
 164+ highlight: "« L",
 165+ expected: '<span class="highlight">«</span> <span class="highlight">L</span> \'oiseau est sur l’île »'
 166+ },
 167+ {
162168 desc: 'Test 026: ru Russian',
163169 text: 'Праведники мира',
164170 highlight: 'Праведники мира',

Follow-up revisions

RevisionCommit summaryAuthorDate
r95344follow up for r95341 , test case 025a corrected the expected resultwikinaut22:20, 23 August 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   22:12, 23 August 2011

The highlighter selects both occurrences of the letter 'l', but your expected text selects only one.

As far as I can tell this is designed behavior... but since it's not specified or anything it can be hard to tell, I suppose. :)

#Comment by Wikinaut (talk | contribs)   22:21, 23 August 2011

Yes, it works as designed now. I think all related commits should get an "ok", see my detailed test cases.

#Comment by Brion VIBBER (talk | contribs)   22:24, 23 August 2011

Looks good in r95344, thanks!

Status & tagging log