r95339 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r95338‎ | r95339 | r95340 >
Date:21:42, 23 August 2011
Author:jeroendedauw
Status:ok (Comments)
Tags:
Comment:
up rel notes
Modified paths:
  • /trunk/extensions/Maps/RELEASE-NOTES (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/RELEASE-NOTES
——@@ -10,7 +10,9 @@
1111 === Maps 1.0.2 ===
1212 (2011-08-xx)
1313
14 -* Fixed Google Maps v3 JavaScript issue when using Google Earth on unsupported systems.
 14+* Fixed Google Maps v3 JavaScript issue occuring when using Google Earth on unsupported systems.
 15+* Fixed Google Maps v3 JavaScript issue occuring on MediaWiki 1.17 due to buggy mw.config.get.
 16+* Fixed internationalization of distances (bug 30467).
1517
1618 === Maps 1.0.1 ===
1719 (2011-08-17)

Comments

#Comment by Nikerabbit (talk | contribs)   05:40, 24 August 2011

Did you report this or has it been fixed already? 

+* Fixed Google Maps v3 JavaScript issue occuring on MediaWiki 1.17 due to buggy mw.config.get.
#Comment by Jeroen De Dauw (talk | contribs)   05:45, 24 August 2011

Turns out that the issue did not lie with mw.config.get, but with $wgOut->addScript. In 1.17, when you do mw.config.set in scripts passed to this method, you're note able to access these via config.get, while this does work in later versions of MW. I figure this is simply unsupported behaviour in 1.17 rather then an actual bug.

#Comment by Catrope (talk | contribs)   09:15, 24 August 2011

That's pretty much right, yes.

Status & tagging log