r94761 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94760‎ | r94761 | r94762 >
Date:14:10, 17 August 2011
Author:dantman
Status:ok
Tags:
Comment:
Followup r80248; Fix inverted message exists tests in ProtectionForm.
Modified paths:
  • /trunk/phase3/includes/ProtectionForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ProtectionForm.php
@@ -357,7 +357,7 @@
358358 $msg = wfMessage( 'restriction-' . $action );
359359 $out .= "<tr><td>".
360360 Xml::openElement( 'fieldset' ) .
361 - Xml::element( 'legend', null, $msg->exists() ? $action : $msg->text() ) .
 361+ Xml::element( 'legend', null, $msg->exists() ? $msg->text() : $action ) .
362362 Xml::openElement( 'table', array( 'id' => "mw-protect-table-$action" ) ) .
363363 "<tr><td>" . $this->buildSelector( $action, $selected ) . "</td></tr><tr><td>";
364364
@@ -569,7 +569,7 @@
570570 return wfMsg( 'protect-default' );
571571 } else {
572572 $msg = wfMessage( "protect-level-{$permission}" );
573 - if( !$msg->exists() ) {
 573+ if( $msg->exists() ) {
574574 return $msg->text();
575575 }
576576 return wfMsg( 'protect-fallback', $permission );

Sign-offs

UserFlagDate
Mormegilinspected17:19, 19 August 2011
Mormegiltested17:19, 19 August 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r98609MFT r94761aaron05:40, 1 October 2011
r98754MFT r93431, r94761, r97762, r97772, r97774, r97777, r97817reedy13:10, 3 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80248Implement Message::isBlank and Message::isDisabled....dantman10:51, 14 January 2011

Status & tagging log