r93431 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93430‎ | r93431 | r93432 >
Date:21:12, 28 July 2011
Author:kaldari
Status:ok (Comments)
Tags:
Comment:
off-white background color matting should be applied only within the thumbnail box, not to the gallerybox; also there is no point in printing the off-white matting, so I removed it completely from the print version
Modified paths:
  • /trunk/phase3/skins/common/commonPrint.css (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/commonPrint.css
@@ -240,7 +240,6 @@
241241 /* Galleries (see shared.css for more info) */
242242 li.gallerybox {
243243 vertical-align: top;
244 - background-color: #f9f9f9;
245244 border: solid 2px white;
246245 display: -moz-inline-box;
247246 display: inline-block;
Index: trunk/phase3/skins/common/shared.css
@@ -543,7 +543,6 @@
544544 /* Don't forget to update commonPrint.css */
545545 li.gallerybox {
546546 vertical-align: top;
547 - background-color: #f9f9f9;
548547 border: solid 2px white;
549548 display: -moz-inline-box;
550549 display: inline-block;
@@ -570,6 +569,7 @@
571570 li.gallerybox div.thumb {
572571 text-align: center;
573572 border: 1px solid #ccc;
 573+ background-color: #f9f9f9;
574574 margin: 2px;
575575 }
576576

Follow-up revisions

RevisionCommit summaryAuthorDate
r984441.18wmf1 MFT r93431, r98076, r98185reedy20:32, 29 September 2011
r98754MFT r93431, r94761, r97762, r97772, r97774, r97777, r97817reedy13:10, 3 October 2011
r98794Merge r93431, seems missing from r98754reedy18:49, 3 October 2011

Comments

#Comment by G.Hagedorn (talk | contribs)   08:31, 30 September 2011

please consider tagging for 1.18 as well

Status & tagging log