r94460 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r94459‎ | r94460 | r94461 >
Date:14:20, 14 August 2011
Author:dantman
Status:ok
Tags:
Comment:
Followup r94353; Use !== null since that's what we use in core.
Modified paths:
  • /trunk/phase3/includes/interwiki/Interwiki.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/interwiki/Interwiki.php
——@@ -321,7 +321,7 @@
322322 */
323323 public function getURL( $title = null ) {
324324 $url = $this->mURL;
325 - if( isset($title) ) {
 325+ if( $title !== null ) {
326326 $url = str_replace( "$1", wfUrlencode( $title ), $url );
327327 }
328328 return $url;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94353Followup r94349; Interwiki::getURL used `$title != null` to test if the $titl...dantman14:55, 12 August 2011

Status & tagging log