r93767 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93766‎ | r93767 | r93768 >
Date:16:33, 2 August 2011
Author:aaron
Status:ok
Tags:
Comment:
Do r93697 change properly, to avoid loose-typing problems if this ends up getting used for non-objects.
Modified paths:
  • /trunk/extensions/MobileFrontend/library/WURFL/Storage/Mwmemcache.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/library/WURFL/Storage/Mwmemcache.php
@@ -50,7 +50,7 @@
5151 public function load( $objectId ) {
5252 global $wgMemc;
5353 $value = $wgMemc->get( $this->encode( $this->namespace, $objectId ) );
54 - return $value ? $value : null; // WURFL expects null on cache miss
 54+ return ( $value !== false ) ? $value : null; // WURFL expects null on cache miss
5555 }
5656
5757 public function clear() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r93773MFT r93767reedy18:19, 2 August 2011
r1049101.18wmf1: MFT r93767 - r104893preilly22:52, 1 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93697Ported r93695 to /trunkaaron00:27, 2 August 2011

Status & tagging log