r104893 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104892‎ | r104893 | r104894 >
Date:20:26, 1 December 2011
Author:preilly
Status:ok
Tags:
Comment:
fix full screen results
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)
  • /trunk/extensions/MobileFrontend/javascripts/beta_opensearch.js (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/beta_common.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/javascripts/beta_opensearch.js
@@ -16,6 +16,8 @@
1717 var sb = document.getElementById( 'searchbox' );
1818 var logo = document.getElementById( 'logo' );
1919 var goButton = document.getElementById( 'goButton' );
 20+var content = document.getElementById( 'content' );
 21+var footer = document.getElementById( 'footer' );
2022
2123 function hideResults() {
2224 results.style.display = 'none';
@@ -49,6 +51,8 @@
5052 results.style.top = ( sq.offsetTop + sq.offsetHeight ) + pixels;
5153 results.style.width = document.body.clientWidth + pixels;
5254 results.style.minHeight = '100%';
 55+ content.style.display = 'none';
 56+ footer.style.display = 'none';
5357 results.style.borderTop = 'solid 1px #A6A6A6';
5458 results.style.backgroundColor = '#E6E6E6';
5559 results.style.paddingTop = 5 + pixels;
@@ -74,6 +78,12 @@
7579 }
7680
7781 function removeResults() {
 82+ if ( content ) {
 83+ content.style.display = 'block';
 84+ }
 85+ if ( footer ) {
 86+ footer.style.display = 'block';
 87+ }
7888 if ( ol ) {
7989 if ( sq ) {
8090 logo.style.visibility = 'visible';
Index: trunk/extensions/MobileFrontend/stylesheets/beta_common.css
@@ -1,11 +1,7 @@
2 -html {
3 - min-height: 100%;
4 -}
5 -
6 -body {
 2+html, body {
73 margin: 0px;
84 padding: 0px;
9 - min-height: 100%;
 5+ height: 100%;
106 }
117
128 .clearlink {
Index: trunk/extensions/MobileFrontend/MobileFrontend.php
@@ -88,7 +88,7 @@
8989 }
9090
9191 class ExtMobileFrontend {
92 - const VERSION = '0.5.87';
 92+ const VERSION = '0.5.88';
9393
9494 /**
9595 * @var DOMDocument
@@ -1037,7 +1037,7 @@
10381038 $commonAttributes = array( 'mp-tfa', 'mp-itn' );
10391039
10401040 $content = $this->mainPage->createElement( 'div' );
1041 - $content->setAttribute( 'id', 'main_box' );
 1041+ $content->setAttribute( 'id', 'content' );
10421042
10431043 if ( $featuredArticle ) {
10441044 $h2FeaturedArticle = $this->mainPage->createElement( 'h2', self::$messages['mobile-frontend-featured-article'] );

Follow-up revisions

RevisionCommit summaryAuthorDate
r1049101.18wmf1: MFT r93767 - r104893preilly22:52, 1 December 2011

Status & tagging log