r93766 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93765‎ | r93766 | r93767 >
Date:16:31, 2 August 2011
Author:ialex
Status:ok
Tags:
Comment:
Per Platonides, follow-up r93758: rename ParserOutput::addOutputPage() to ParserOutput::addOutputPageMetadata() to match its behaviour
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)
  • /trunk/phase3/includes/parser/ParserOutput.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -3267,7 +3267,7 @@
32683268 $ret = SpecialPageFactory::capturePath( $title, $context );
32693269 if ( $ret ) {
32703270 $text = $context->getOutput()->getHTML();
3271 - $this->mOutput->addOutputPage( $context->getOutput() );
 3271+ $this->mOutput->addOutputPageMetadata( $context->getOutput() );
32723272 $found = true;
32733273 $isHTML = true;
32743274 $this->disableCache();
Index: trunk/phase3/includes/parser/ParserOutput.php
@@ -361,7 +361,7 @@
362362 *
363363 * @param $out OutputPage object
364364 */
365 - public function addOutputPage( OutputPage $out ) {
 365+ public function addOutputPageMetadata( OutputPage $out ) {
366366 $this->addModules( $out->getModules() );
367367 $this->addModuleScripts( $out->getModuleScripts() );
368368 $this->addModuleStyles( $out->getModuleStyles() );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93758* (bug 15558) Allow includable special pages to be parameterized using wiki s...ialex15:40, 2 August 2011

Status & tagging log