r93581 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r93580‎ | r93581 | r93582 >
Date:09:25, 31 July 2011
Author:diebuche
Status:reverted (Comments)
Tags:
Comment:
Fixing Bug 27540 : width of <gallery> always 100%, by setting display to inline-block.
Modified paths:
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
——@@ -566,17 +566,17 @@
567567 display: inline-block;
568568 }
569569
570 -ul.gallery, li.gallerybox {
571 - zoom: 1;
572 - *display: inline;
573 -}
574 -
575570 ul.gallery {
576571 margin: 2px;
577572 padding: 2px;
578 - display: block;
 573+ display: inline-block;
579574 }
580575
 576+ul.gallery, li.gallerybox {
 577+ zoom: 1;
 578+ display: inline !ie;
 579+}
 580+
581581 li.gallerycaption {
582582 font-weight: bold;
583583 text-align: center;

Follow-up revisions

RevisionCommit summaryAuthorDate
r105995back to display:block; for galleries...hashar09:24, 13 December 2011

Comments

#Comment by Fomafix (talk | contribs)   14:47, 18 August 2011

ul.gallery { display: inline-block; } can effect white space next to floating objects:

Box
  • Köln Panorama.jpg
  • Köln Panorama.jpg
  • Köln Panorama.jpg
  • Köln Panorama.jpg
  • Köln Panorama.jpg
  • Köln Panorama.jpg

ul.gallery { display: block; } interacts better with floating objects:

Box
  • Köln Panorama.jpg
  • Köln Panorama.jpg
  • Köln Panorama.jpg
  • Köln Panorama.jpg
  • Köln Panorama.jpg
  • Köln Panorama.jpg

Here a real example for such a constellation: de:Europium#Eigenschaften

#Comment by Bawolff (talk | contribs)   21:25, 23 October 2011

Seems to cause problems for me on categories with just a few images, see bug 31550

#Comment by Fomafix (talk | contribs)   07:15, 26 October 2011

Yes, this is an other disadvantage of ul.gallery { display: inline-block; }:

Text before

  • Köln Panorama.jpg
  • Köln Panorama.jpg
  • Köln Panorama.jpg

Text after

With ul.gallery { display: block; } this can't happen:

Text before

  • Köln Panorama.jpg
  • Köln Panorama.jpg
  • Köln Panorama.jpg

Text after

#Comment by Hashar (talk | contribs)   09:25, 13 December 2011

I have reverted this change with r105995. Gallery are back to display:block;

Bug 27540 was reopened at some point, so it is still open.

Status & tagging log