r105995 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r105994‎ | r105995 | r105996 >
Date:09:24, 13 December 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
back to display:block; for galleries

Display inline-block show weird behaviour when the gallery has text before
and after. Fomafix on cr of r93581 gave us some examples.

Reverts r93581
Modified paths:
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
——@@ -738,18 +738,18 @@
739739 display: inline-block;
740740 }
741741
 742+ul.gallery,
 743+li.gallerybox {
 744+ zoom: 1;
 745+ *display: inline;
 746+}
 747+
742748 ul.gallery {
743749 margin: 2px;
744750 padding: 2px;
745 - display: inline-block;
 751+ display: block;
746752 }
747753
748 -ul.gallery,
749 -li.gallerybox {
750 - zoom: 1;
751 - display: inline !ie;
752 -}
753 -
754754 li.gallerycaption {
755755 font-weight: bold;
756756 text-align: center;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93581Fixing Bug 27540 : width of <gallery> always 100%, by setting display to inl...diebuche09:25, 31 July 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   22:15, 20 December 2011

What does "*display: inline" mean?

#Comment by Hashar (talk | contribs)   22:26, 20 December 2011

That one is an old browser hack. Since this revision is just a revert I did not investigate that much.

Any way, thanks to blame and revision history it is an undocumented browser hack added by simetrical in r77411. Roan had the confirmation when attempting to remove the hack in r78158.

Wish we could get it documented though.

#Comment by Brion VIBBER (talk | contribs)   22:47, 20 December 2011

Can you add /* a comment */ about it? :)

#Comment by Hashar (talk | contribs)   09:21, 21 December 2011

On further inspection of r93581. I suspect it is a browser hack for Internet Explorer. Maybe: 

*display: inline;
^

Is equivalent to: 

display: inline !ie;
                ^^^

That was part of r93581 change.

#Comment by Tim Starling (talk | contribs)   23:47, 21 December 2011

w:CSS filter#Star hack

It's for IE 7 and earlier.

Status & tagging log