r93580 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93579‎ | r93580 | r93581 >
Date:09:24, 31 July 2011
Author:erik
Status:ok
Tags:
Comment:
1) Replace remaining instance of word 'mood' in the UI
2) Show feedback box when MoodBar is opened
3) Disable button when MoodBar is opened (is activated once mood is selected)
4) Focus feedback box once mood is selected.
Modified paths:
  • /trunk/extensions/MoodBar/MoodBar.i18n.php (modified) (history)
  • /trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.css (modified) (history)
  • /trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/MoodBar.i18n.php
@@ -51,7 +51,7 @@
5252 'moodbar-error-title' => 'Oops!',
5353 'moodbar-loading-subtitle' => 'We are sharing your feedback…',
5454 'moodbar-success-subtitle' => 'Sharing your editing experience helps us improve $1.',
55 - 'moodbar-error-subtitle' => 'Something went wrong! Please try sharing your mood again later.',
 55+ 'moodbar-error-subtitle' => 'Something went wrong! Please try sharing your feedback again later.',
5656 // Special:MoodBar
5757 'right-moodbar-view' => 'View and export MoodBar feedback',
5858 'moodbar-admin-title' => 'MoodBar feedback',
Index: trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.css
@@ -51,12 +51,16 @@
5252 font-size: 12px;
5353 }
5454
55 -.mw-moodBar-form,
 55+
5656 .mw-moodBar-overlayWhatContent {
5757 display: none;
5858 overflow: hidden;
5959 }
6060
 61+.mw-moodBar-form {
 62+ overflow: hidden;
 63+}
 64+
6165 .mw-moodBar-formNote {
6266 float: right;
6367 font-size: 10px;
Index: trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.js
@@ -25,7 +25,7 @@
2626 <div class="mw-moodBar-formInputs">\
2727 <textarea rows="3" maxlength="140" class="mw-moodBar-formInput" /></textarea>\
2828 <div class="mw-moodBar-privacy"></div>\
29 - <input type="button" class="mw-moodBar-formSubmit" />\
 29+ <input type="button" class="mw-moodBar-formSubmit" disabled="disabled" />\
3030 </div>\
3131 </div>\
3232 <span class="mw-moodBar-overlayWhat">\
@@ -108,7 +108,8 @@
109109 .localize()
110110 .click( function( e ) {
111111 var $el = $( this );
112 - mb.ui.overlay.find( '.mw-moodBar-form' ).slideDown( 'fast' );
 112+ mb.ui.overlay.find( '.mw-moodBar-formSubmit').removeAttr('disabled');
 113+ mb.ui.overlay.find( '.mw-moodBar-formInput' ).focus();
113114 $mwMoodBarTypes.addClass( 'mw-moodBar-types-select' );
114115 mb.feedbackItem.type = $el.attr( 'rel' );
115116 $el.addClass( 'mw-moodBar-selected' );

Status & tagging log