r93157 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93156‎ | r93157 | r93158 >
Date:02:44, 26 July 2011
Author:dantman
Status:ok
Tags:
Comment:
Followup r93132, misplaced ) caused 'dirname() expects exactly 1 parameter, 3 given' error.
Modified paths:
  • /trunk/phase3/includes/media/Bitmap.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/Bitmap.php
@@ -157,7 +157,7 @@
158158 }
159159
160160 # Try to make a target path for the thumbnail
161 - if ( !wfMkdirParents( dirname( $dstPath, null, __METHOD__ ) ) ) {
 161+ if ( !wfMkdirParents( dirname( $dstPath ), null, __METHOD__ ) ) {
162162 wfDebug( __METHOD__ . ": Unable to create thumbnail destination directory, falling back to client scaling\n" );
163163 return $this->getClientScalingThumbnailImage( $image, $scalerParams );
164164 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r93162Followup r93157, missing another one of the stray )'s.dantman03:36, 26 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93132Adding __METHOD__ to parameters passed to wfMkdirParents()reedy22:01, 25 July 2011

Status & tagging log