r93158 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93157‎ | r93158 | r93159 >
Date:02:57, 26 July 2011
Author:dantman
Status:deferred
Tags:
Comment:
Revert r91654 for now. This change alone breaks the code. It should be acompanied by a change to core and a feature test.
Modified paths:
  • /trunk/extensions/OpenGraphMeta/OpenGraphMeta.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenGraphMeta/OpenGraphMeta.php
@@ -92,9 +92,9 @@
9393 $meta["fb:admins"] = $egFacebookAdmins;
9494
9595 foreach( $meta as $property => $value ) {
96 - if ( $value ){
97 - $out->addMeta("property:$property", $value );
98 - }
 96+ if ( $value )
 97+ //$out->addMeta($property, $value ); // FB wants property= instead of name= blech, is that even valid html?
 98+ $out->addHeadItem("meta:property:$property", " ".Html::element( 'meta', array( 'property' => $property, 'content' => $value ) )."\n");
9999 }
100100
101101 return true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91654Put the OpenGraphMeta info into meta tags section of OutputPage. Makes it mor...sean_colombo17:32, 7 July 2011

Status & tagging log