r93162 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93161‎ | r93162 | r93163 >
Date:03:36, 26 July 2011
Author:dantman
Status:ok
Tags:
Comment:
Followup r93157, missing another one of the stray )'s.
Modified paths:
  • /trunk/phase3/includes/media/Bitmap.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/Bitmap.php
@@ -234,7 +234,7 @@
235235 }
236236
237237 if ( $scaler != 'client' && $dstPath ) {
238 - if ( !wfMkdirParents( dirname( $dstPath, null, __METHOD__ ) ) ) {
 238+ if ( !wfMkdirParents( dirname( $dstPath ), null, __METHOD__ ) ) {
239239 # Unable to create a path for the thumbnail
240240 return 'client';
241241 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93157Followup r93132, misplaced ) caused 'dirname() expects exactly 1 parameter, 3...dantman02:44, 26 July 2011

Status & tagging log