r91927 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r91926‎ | r91927 | r91928 >
Date:23:41, 11 July 2011
Author:brion
Status:ok (Comments)
Tags:
Comment:
Revert r91870, r91873 -- seems to be trying to remove the 'view' action on diff views; diffs are a subset of regular page views, like old page views, and don't have a separate action.
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
——@@ -371,8 +371,6 @@
372372 # If we got diff in the query, we want to see a diff page instead of the article.
373373 if ( $wgRequest->getCheck( 'diff' ) ) {
374374 wfDebug( __METHOD__ . ": showing diff page\n" );
375 - # Manually setting action=diff. Bug 25800
376 - $wgRequest->setVal( 'action', 'historysubmit' );
377375 $this->showDiffPage();
378376 wfProfileOut( __METHOD__ );
379377

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91870wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages w...diebuche10:54, 11 July 2011
r91873r91870 : Got tricked into believing it was action=diff instead of action=hist...diebuche11:05, 11 July 2011

Comments

#Comment by DieBuche (talk | contribs)   23:51, 11 July 2011

Replied on BZ.

Status & tagging log