r91870 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r91869‎ | r91870 | r91871 >
Date:10:54, 11 July 2011
Author:diebuche
Status:reverted (Comments)
Tags:
Comment:
wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a &action parameter. Bug 25800
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
——@@ -371,6 +371,8 @@
372372 # If we got diff in the query, we want to see a diff page instead of the article.
373373 if ( $wgRequest->getCheck( 'diff' ) ) {
374374 wfDebug( __METHOD__ . ": showing diff page\n" );
 375+ # Manually setting action=diff. Bug 25800
 376+ $wgRequest->setVal( 'action', 'diff' );
375377 $this->showDiffPage();
376378 wfProfileOut( __METHOD__ );
377379

Follow-up revisions

RevisionCommit summaryAuthorDate
r91873r91870 : Got tricked into believing it was action=diff instead of action=hist...diebuche11:05, 11 July 2011
r91927Revert r91870, r91873 -- seems to be trying to remove the 'view' action on di...brion23:41, 11 July 2011
r108343[mw.config] wgAction shouldn't use direct URL values...krinkle01:34, 8 January 2012

Comments

#Comment by Brion VIBBER (talk | contribs)   23:38, 11 July 2011

This seems wrong; diff views default to a special subset of page views, so having action be 'view' is expected.

#Comment by Brion VIBBER (talk | contribs)   23:42, 11 July 2011

Reverted in r91927.

Status & tagging log