r91873 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r91872‎ | r91873 | r91874 >
Date:11:05, 11 July 2011
Author:diebuche
Status:reverted (Comments)
Tags:
Comment:
r91870 : Got tricked into believing it was action=diff instead of action=historysubmit
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
——@@ -372,7 +372,7 @@
373373 if ( $wgRequest->getCheck( 'diff' ) ) {
374374 wfDebug( __METHOD__ . ": showing diff page\n" );
375375 # Manually setting action=diff. Bug 25800
376 - $wgRequest->setVal( 'action', 'diff' );
 376+ $wgRequest->setVal( 'action', 'historysubmit' );
377377 $this->showDiffPage();
378378 wfProfileOut( __METHOD__ );
379379

Follow-up revisions

RevisionCommit summaryAuthorDate
r91927Revert r91870, r91873 -- seems to be trying to remove the 'view' action on di...brion23:41, 11 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91870wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages w...diebuche10:54, 11 July 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   23:38, 11 July 2011

This seems wrong; diff views default to a special subset of page views, so having action be 'view' is expected.

#Comment by Brion VIBBER (talk | contribs)   23:42, 11 July 2011

Reverted in r91927.

Status & tagging log