r91759 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91758‎ | r91759 | r91760 >
Date:21:27, 8 July 2011
Author:krinkle
Status:reverted
Tags:
Comment:
Reverting r91756 per CR and bug 26470
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/resources/Resources.php (modified) (history)
  • /trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css (modified) (history)
  • /trunk/phase3/resources/mediawiki.action/mediawiki.action.view.dblClickEdit.js (added) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -2308,11 +2308,8 @@
23092309 $this->getTitle()->getNamespace() != NS_SPECIAL &&
23102310 in_array( $action, array( 'view', 'purge' ) ) &&
23112311 $this->getUser()->getOption( 'editondblclick' )
2312 - )
2313 - {
2314 - $editUrl = $this->getTitle()->getLocalUrl( $sk->editUrlOptions() );
2315 - $bodyAttrs['ondblclick'] = "document.location = '" .
2316 - Xml::escapeJsString( $editUrl ) . "'";
 2312+ ) {
 2313+ $this->addModules( 'mediawiki.action.view.dblClickEdit' );
23172314 }
23182315
23192316 # Classes for LTR/RTL directionality support
Index: trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css
@@ -31,6 +31,7 @@
3232 font-weight: bold;
3333 white-space: -moz-pre-wrap;
3434 white-space: pre-wrap;
 35+ text-decoration: none;
3536 }
3637
3738 table.diff {
Index: trunk/phase3/resources/mediawiki.action/mediawiki.action.view.dblClickEdit.js
@@ -0,0 +1,12 @@
 2+/*
 3+ * This module enables double-click-to-edit functionality
 4+ */
 5+jQuery( function( $ ) {
 6+ var url = $('#ca-edit a').attr('href');
 7+ if ( url ) {
 8+ mw.util.$content.dblclick( function( e ) {
 9+ e.preventDefault();
 10+ window.location = url;
 11+ } );
 12+ }
 13+} );
Property changes on: trunk/phase3/resources/mediawiki.action/mediawiki.action.view.dblClickEdit.js
___________________________________________________________________
Added: svn:eol-style
114 + native
Index: trunk/phase3/resources/Resources.php
@@ -502,6 +502,9 @@
503503 'jquery.byteLimit',
504504 ),
505505 ),
 506+ 'mediawiki.action.view.dblClickEdit' => array(
 507+ 'scripts' => 'resources/mediawiki.action/mediawiki.action.view.dblClickEdit.js',
 508+ ),
506509 'mediawiki.action.view.rightClickEdit' => array(
507510 'scripts' => 'resources/mediawiki.action/mediawiki.action.view.rightClickEdit.js',
508511 ),
Index: trunk/phase3/skins/common/shared.css
@@ -95,15 +95,6 @@
9696 clear: both;
9797 }
9898
99 -/*
100 -* Add a checkered background image on hover for file description pages. Bug 26470
101 -*/
102 -.filehistory a img:hover,
103 -#file img:hover {
104 - /* @embed */
105 - background: white url(images/Checker-16x16.png) repeat;
106 -}
107 -
10899 table.filehistory th,
109100 table.filehistory td {
110101 vertical-align: top;

Follow-up revisions

RevisionCommit summaryAuthorDate
r91760Selfrevert r91759. Messed up working-copykrinkle21:28, 8 July 2011
r91761Reverting r91756 per CR and bug 26470krinkle21:29, 8 July 2011
r96270(bug 26470) add checkered background on files pageshashar06:28, 5 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91756Bug 26470 : Add checkered background image for transparent images on hoverdiebuche20:34, 8 July 2011

Status & tagging log