r96270 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96269‎ | r96270 | r96271 >
Date:06:28, 5 September 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
(bug 26470) add checkered background on files pages
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -184,6 +184,16 @@
185185 }
186186
187187 /**
 188+ * Add a checkered background image on hover for file
 189+ * description pages. (bug 26470)
 190+ */
 191+.filehistory a img,
 192+#file img:hover {
 193+ /* @embed */
 194+ background: white url(images/Checker-16x16.png) repeat;
 195+}
 196+
 197+/**
188198 * rev_deleted stuff
189199 */
190200 li span.deleted,
@@ -974,4 +984,4 @@
975985 /* bug 12205 */
976986 #mw-credits a {
977987 unicode-bidi: embed;
978 -}
\ No newline at end of file
 988+}
Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -53,6 +53,7 @@
5454 * (bug 16428) Include permalink in printable version
5555 * (bug 96170) Add array support for space-separated list attributes (like
5656 'class') in the Html helper class.
 57+* (bug 26470) Add checkered background image on hover on files pages.
5758
5859 === Bug fixes in 1.19 ===
5960 * $wgUploadNavigationUrl should be used for file redlinks if

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91756Bug 26470 : Add checkered background image for transparent images on hoverdiebuche20:34, 8 July 2011
r91759Reverting r91756 per CR and bug 26470krinkle21:27, 8 July 2011
r91761Reverting r91756 per CR and bug 26470krinkle21:29, 8 July 2011

Comments

#Comment by Krinkle (talk | contribs)   01:13, 8 September 2011

Looks good. Example for this image - http://translatewiki.net/wiki/File:Openstreetmap_logo.svg - used on http://translatewiki.net/wiki/Translating:OpenStreetMap

  • No checkbox stuff in-article
  • On the file page the primary thumbnail on top shows transparency when hovering it
  • The file history section on the bottom shows it by default for comparison.
#Comment by Hashar (talk | contribs)   06:10, 8 September 2011

Thanks for the review!

Status & tagging log