r91760 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91759‎ | r91760 | r91761 >
Date:21:28, 8 July 2011
Author:krinkle
Status:ok
Tags:
Comment:
Selfrevert r91759. Messed up working-copy
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/resources/Resources.php (modified) (history)
  • /trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css (modified) (history)
  • /trunk/phase3/resources/mediawiki.action/mediawiki.action.view.dblClickEdit.js (deleted) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -2308,8 +2308,11 @@
23092309 $this->getTitle()->getNamespace() != NS_SPECIAL &&
23102310 in_array( $action, array( 'view', 'purge' ) ) &&
23112311 $this->getUser()->getOption( 'editondblclick' )
2312 - ) {
2313 - $this->addModules( 'mediawiki.action.view.dblClickEdit' );
 2312+ )
 2313+ {
 2314+ $editUrl = $this->getTitle()->getLocalUrl( $sk->editUrlOptions() );
 2315+ $bodyAttrs['ondblclick'] = "document.location = '" .
 2316+ Xml::escapeJsString( $editUrl ) . "'";
23142317 }
23152318
23162319 # Classes for LTR/RTL directionality support
Index: trunk/phase3/resources/mediawiki.action/mediawiki.action.view.dblClickEdit.js
@@ -1,12 +0,0 @@
2 -/*
3 - * This module enables double-click-to-edit functionality
4 - */
5 -jQuery( function( $ ) {
6 - var url = $('#ca-edit a').attr('href');
7 - if ( url ) {
8 - mw.util.$content.dblclick( function( e ) {
9 - e.preventDefault();
10 - window.location = url;
11 - } );
12 - }
13 -} );
Index: trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css
@@ -31,7 +31,6 @@
3232 font-weight: bold;
3333 white-space: -moz-pre-wrap;
3434 white-space: pre-wrap;
35 - text-decoration: none;
3635 }
3736
3837 table.diff {
Index: trunk/phase3/resources/Resources.php
@@ -502,9 +502,6 @@
503503 'jquery.byteLimit',
504504 ),
505505 ),
506 - 'mediawiki.action.view.dblClickEdit' => array(
507 - 'scripts' => 'resources/mediawiki.action/mediawiki.action.view.dblClickEdit.js',
508 - ),
509506 'mediawiki.action.view.rightClickEdit' => array(
510507 'scripts' => 'resources/mediawiki.action/mediawiki.action.view.rightClickEdit.js',
511508 ),
Index: trunk/phase3/skins/common/shared.css
@@ -95,6 +95,15 @@
9696 clear: both;
9797 }
9898
 99+/*
 100+* Add a checkered background image on hover for file description pages. Bug 26470
 101+*/
 102+.filehistory a img:hover,
 103+#file img:hover {
 104+ /* @embed */
 105+ background: white url(images/Checker-16x16.png) repeat;
 106+}
 107+
99108 table.filehistory th,
100109 table.filehistory td {
101110 vertical-align: top;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91759Reverting r91756 per CR and bug 26470krinkle21:27, 8 July 2011

Status & tagging log