r91651 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91650‎ | r91651 | r91652 >
Date:16:59, 7 July 2011
Author:demon
Status:ok (Comments)
Tags:
Comment:
(bug 27410) The tag filter on a history page should be within a <label> element. Patch by The Evil IP Address.

Also remove inclusion protection for the 800th time: if a file only has classes, you don't need to do this :)
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/ChangeTags.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -145,6 +145,7 @@
146146 unneeded CSS flipping of quickbar. Instead, introduce option 5 which sets
147147 left/right according to the directionality of your interface language.
148148 * (bug 19514) Unordered list list-style-image should be IE6-compatible (8-bit)
 149+* (bug 27410) The tag filter on a history page is now within a <label> element
149150
150151 === API changes in 1.19 ===
151152 * BREAKING CHANGE: action=watch now requires POST and token.
Index: trunk/phase3/CREDITS
@@ -148,6 +148,7 @@
149149 * Stefano Codari
150150 * Str4nd
151151 * svip
 152+* The Evil IP address
152153 * Tisane
153154 * Tobias Müller
154155 * Umherirrender
Index: trunk/phase3/includes/ChangeTags.php
@@ -1,8 +1,5 @@
22 <?php
33
4 -if( !defined( 'MEDIAWIKI' ) )
5 - die;
6 -
74 class ChangeTags {
85 static function formatSummaryRow( $tags, $page ) {
96 if( !$tags )
@@ -165,7 +162,8 @@
166163 if ( !$wgUseTagFilter || !count( self::listDefinedTags() ) )
167164 return $fullForm ? '' : array();
168165
169 - $data = array( wfMsgExt( 'tag-filter', 'parseinline' ), Xml::input( 'tagfilter', 20, $selected ) );
 166+ $data = array( Xml::label( wfMsgExt( 'tag-filter', 'parseinline' ), 'tagfilter' ),
 167+ Xml::input( 'tagfilter', 20, $selected ) );
170168
171169 if ( !$fullForm ) {
172170 return $data;

Follow-up revisions

RevisionCommit summaryAuthorDate
r91783Fix for r91651: don't escape HTMLialex09:01, 9 July 2011

Comments

#Comment by SPQRobin (talk | contribs)   19:31, 8 July 2011

This escapes the wikilink (in the message), so you see <a href="https://www.mediawiki.org/mw/index.php/Special:Tags" title="Special:Tags">Labelfilter</a>

Status & tagging log