r91650 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r91649‎ | r91650 | r91651 >
Date:16:52, 7 July 2011
Author:demon
Status:ok
Tags:
Comment:
Reduce some duplication
Modified paths:
  • /trunk/phase3/includes/installer/WebInstallerOutput.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstallerOutput.php
@@ -113,11 +113,11 @@
114114 }
115115
116116 /**
117 - * URL for index.php?css=foobar
 117+ * <link> to index.php?css=foobar for the <head>
118118 * @return String
119119 */
120120 private function getCssUrl( ) {
121 - return $_SERVER['PHP_SELF'] . '?css=' . $this->getDir();
 121+ return Html::linkedStyle( $_SERVER['PHP_SELF'] . '?css=' . $this->getDir() );
122122 }
123123
124124 public function useShortHeader( $use = true ) {
@@ -206,7 +206,7 @@
207207 <meta http-equiv="Content-type" content="text/html; charset=utf-8" />
208208 <title><?php $this->outputTitle(); ?></title>
209209 <?php echo Html::linkedStyle( '../skins/common/shared.css' ) . "\n"; ?>
210 - <?php echo Html::linkedStyle( $this->getCssUrl() ) . "\n"; ?>
 210+ <?php echo $this->getCssUrl() . "\n"; ?>
211211 <?php echo Html::inlineScript( "var dbTypes = " . Xml::encodeJsVar( $dbTypes ) ) . "\n"; ?>
212212 <?php echo $this->getJQuery() . "\n"; ?>
213213 <?php echo Html::linkedScript( '../skins/common/config.js' ) . "\n"; ?>
@@ -260,7 +260,7 @@
261261 <meta http-equiv="Content-type" content="text/html; charset=utf-8" />
262262 <meta name="robots" content="noindex, nofollow" />
263263 <title><?php $this->outputTitle(); ?></title>
264 - <?php echo Html::linkedStyle( $this->getCssUrl() ) . "\n"; ?>
 264+ <?php echo $this->getCssUrl() . "\n"; ?>
265265 <?php echo $this->getJQuery(); ?>
266266 <?php echo Html::linkedScript( '../skins/common/config.js' ); ?>
267267 </head>

Status & tagging log