r91652 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r91651‎ | r91652 | r91653 >
Date:17:17, 7 July 2011
Author:brion
Status:ok
Tags:
Comment:
Partial (?) fix for bug 29753 -- wrong Firefox version comparison for non-Mac Firefox 2+ accesskey tooltip. However, this code IS NOT YET USED which is very suspicious. An earlier version of this code is wikibits.js is still being used for some reason, which indicates a maintenance problem.
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.util.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.util.js
——@@ -53,8 +53,8 @@
5454 || profile.name == 'konqueror' ) ) {
5555 util.tooltipAccessKeyPrefix = 'ctrl-';
5656
57 - // Firefox 2.x
58 - } else if ( profile.name == 'firefox' && profile.versionBase == '2' ) {
 57+ // Firefox 2.x and later
 58+ } else if ( profile.name == 'firefox' && profile.versionBase > '1' ) {
5959 util.tooltipAccessKeyPrefix = 'alt-shift-';
6060 }
6161

Follow-up revisions

RevisionCommit summaryAuthorDate
r113214[mw.util.tooltipAccessKeyPrefix] alt-shift for Chrome on Windows...krinkle02:58, 7 March 2012

Status & tagging log