r90968 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r90967‎ | r90968 | r90969 >
Date:15:24, 28 June 2011
Author:catrope
Status:resolved (Comments)
Tags:
Comment:
Move mediawiki.special.js to the correct directory. Followup r90941, r90960
Modified paths:
  • /trunk/phase3/resources/mediawiki.special/mediawiki.special.js (added) (history)
  • /trunk/phase3/resources/mediawiki/mediawiki.special.js (deleted) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.special/mediawiki.special.js
——@@ -0,0 +1,5 @@
 2+( function( $, mw ) {
 3+
 4+ mw.special = {};
 5+
 6+} )( jQuery, mediaWiki );
Property changes on: trunk/phase3/resources/mediawiki.special/mediawiki.special.js
___________________________________________________________________
Added: svn:eol-style
17 + native
Index: trunk/phase3/resources/mediawiki/mediawiki.special.js
——@@ -1,5 +0,0 @@
2 -( function( $, mw ) {
3 -
4 - mw.special = {};
5 -
6 -} )( jQuery, mediaWiki );

Follow-up revisions

RevisionCommit summaryAuthorDate
r90980Update qunit test runner includes for mediawiki.special.js move in r90968brion17:17, 28 June 2011
r90982mw.special.recentchanges fixes:...krinkle17:40, 28 June 2011
r90984mw.special.recentchanges fixes:...krinkle17:56, 28 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90941mediawiki.special as a dumb JS object...hashar05:57, 28 June 2011
r90960Fix r90943: redefined mediawiki.special module that had already been added in...catrope14:28, 28 June 2011

Comments

#Comment by Krinkle (talk | contribs)   17:00, 28 June 2011

Brakes QUnit tests, (mw.special undefined). 

http://toolserver.org/~krinkle/testswarm-tmp-checkouts/r90968/tests/qunit/
#Comment by Brion VIBBER (talk | contribs)   17:17, 28 June 2011

Updated the qunit index.html to pull it from the right path in r90980.

Status & tagging log