r90960 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r90959‎ | r90960 | r90961 >
Date:14:28, 28 June 2011
Author:catrope
Status:resolved (Comments)
Tags:
Comment:
Fix r90943: redefined mediawiki.special module that had already been added in r83789 (!), broke loading of special page-specific CSS by addModuleStyles( 'mediawiki.special' ) . Bug originally reported by Nikerabbit as lack of CSS on Special:Search on TranslateWiki
Modified paths:
  • /trunk/phase3/resources/Resources.php (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/Resources.php
——@@ -510,6 +510,7 @@
511511 /* Special pages */
512512
513513 'mediawiki.special' => array(
 514+ 'scripts' => 'resources/mediawiki.special/mediawiki.special.js',
514515 'styles' => 'resources/mediawiki.special/mediawiki.special.css',
515516 ),
516517 'mediawiki.special.preferences' => array(
——@@ -534,9 +535,6 @@
535536 'scripts' => 'resources/mediawiki.special/mediawiki.special.movePage.js',
536537 'dependencies' => 'jquery.byteLimit',
537538 ),
538 - 'mediawiki.special' => array(
539 - 'scripts' => 'resources/mediawiki/mediawiki.special.js',
540 - ),
541539 'mediawiki.special.recentchanges' => array(
542540 'scripts' => 'resources/mediawiki.special/mediawiki.special.recentchanges.js',
543541 'dependencies' => array( 'mediawiki.special' ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r90968Move mediawiki.special.js to the correct directory. Followup r90941, r90960catrope15:24, 28 June 2011
r90982mw.special.recentchanges fixes:...krinkle17:40, 28 June 2011
r90984mw.special.recentchanges fixes:...krinkle17:56, 28 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83789Spin out all the CSS used on special pages into their own mediawiki.special m...happy-melon22:42, 12 March 2011
r90943Disable ns selector checkboxes when 'all' namespace is selected...hashar06:40, 28 June 2011

Comments

#Comment by Raymond (talk | contribs)   15:23, 28 June 2011

PHP Warning: filemtime(): stat failed for /www/w/resources/mediawiki.special/mediawiki.special.js in /www/w/includes/resourceloader/ResourceLoaderFileModule.php on line 369

#Comment by Hashar (talk | contribs)   15:27, 28 June 2011

The path got changed meantime.

I have originally added the mediawiki.special.js file in: 

resources/mediawiki/

Catrope moved it to the same place the .css is: 

resources/mediawiki.special/

Status & tagging log