r90967 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r90966‎ | r90967 | r90968 >
Date:15:07, 28 June 2011
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Followup r90958 for Translatewiki
Modified paths:
  • /trunk/extensions/Translate/groups/mediawiki-defines.txt (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/groups/mediawiki-defines.txt
——@@ -1844,10 +1844,10 @@
18451845 aliasfile = Wikilog/Wikilog.i18n.alias.php
18461846 magicfile = Wikilog/Wikilog.i18n.magic.php
18471847 optional = wikilog-entry-footer, wikilog-title-item-full, wikilog-feed-title
1848 -optional = wikilog-comment-footer, wikilog-simple-signature
 1848+optional = wikilog-comment-footer, wikilog-simple-signature, wikilove-commons-link
18491849 ignored = wikilog-summary, wikilog-summary-header, wikilog-summary-header-single, wikilog-entry-sub
18501850 ignored = wikilog-entry-header, wikilog-backlink, wikilog-brackets
1851 -ignored = wikilog-comment-header
 1851+ignored = wikilog-comment-header, wikilove-commons-url
18521852
18531853 Wikilog Feed
18541854 file = Wikilog/WlFeed.i18n.php

Follow-up revisions

RevisionCommit summaryAuthorDate
r90975Followup r90958 for Translatewiki and fix for r90967 per JanPaul's CE:...raymond16:01, 28 June 2011
r90983Added qqq comment per suggestion in r90967.janpaul12317:47, 28 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90958Better directions to Wikimedia Commons.janpaul12314:12, 28 June 2011

Comments

#Comment by JanPaul123 (talk | contribs)   15:44, 28 June 2011

Ah, I deliberately added the Commons url so that people can change it to a localised Main Page or instructions page on Commons. Is this the right way to go or not?

#Comment by Raymond (talk | contribs)   16:04, 28 June 2011

Thanks for the explanation. I have changed the key to optional with r90975. Best to add these kind of explanation in the qqq section too (or feel free to edit http://translatewiki.net/wiki/MediaWiki:Wikilove-commons-url/qqq ).

#Comment by JanPaul123 (talk | contribs)   17:33, 28 June 2011

Good point, I'll update the qqq section. Thanks for the swift response!

#Comment by JanPaul123 (talk | contribs)   15:46, 28 June 2011

Also, shouldn't this be under Wiki Love instead of Wikilog? ^_^

Status & tagging log