r90958 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90957‎ | r90958 | r90959 >
Date:14:12, 28 June 2011
Author:janpaul123
Status:ok
Tags:
Comment:
Better directions to Wikimedia Commons.
Modified paths:
  • /trunk/extensions/WikiLove/WikiLove.i18n.php (modified) (history)
  • /trunk/extensions/WikiLove/WikiLove.php (modified) (history)
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.css (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/WikiLove.php
@@ -126,6 +126,9 @@
127127 'wikilove-err-gallery-again',
128128 'wikilove-what-is-this',
129129 'wikilove-anon-warning',
 130+ 'wikilove-commons-text',
 131+ 'wikilove-commons-link',
 132+ 'wikilove-commons-url',
130133 ),
131134 'dependencies' => array(
132135 'jquery.ui.dialog',
Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.css
@@ -226,6 +226,10 @@
227227 resize: none;
228228 }
229229
 230+/*#mw-wikilove-dialog*/ #mw-wikilove-commons-text {
 231+ margin: 5px 0px 5px 15px;
 232+}
 233+
230234 /* add details gallery */
231235 /*#mw-wikilove-dialog*/ #mw-wikilove-gallery {
232236 min-height: 40px;
Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
@@ -84,6 +84,9 @@
8585 <label for="mw-wikilove-image" id="mw-wikilove-image-label"><html:msg key="wikilove-image"/></label>\
8686 <span class="mw-wikilove-note" id="mw-wikilove-image-note"><html:msg key="wikilove-image-example"/></span>\
8787 <input type="text" class="text" id="mw-wikilove-image"/>\
 88+ <div id="mw-wikilove-commons-text">\
 89+ ' + mw.msg( 'wikilove-commons-text', '<a href="' + mw.msg( 'wikilove-commons-url' ) +'" target="_blank">' + mw.msg( 'wikilove-commons-link' ) +'</a>' ) + '\
 90+ </div>\
8891 <label for="mw-wikilove-message" id="mw-wikilove-message-label"><html:msg key="wikilove-enter-message"/></label>\
8992 <span class="mw-wikilove-note" id="mw-wikilove-message-note"><html:msg key="wikilove-omit-sig"/></span>\
9093 <textarea id="mw-wikilove-message"></textarea>\
@@ -244,7 +247,7 @@
245248 $( '#mw-wikilove-title' ).val( currentTypeOrSubtype.title || '' );
246249
247250 // show or hide image label and textbox depending on fields configuration
248 - $( '#mw-wikilove-image, #mw-wikilove-image-label, #mw-wikilove-image-note' )
 251+ $( '#mw-wikilove-image, #mw-wikilove-image-label, #mw-wikilove-image-note, #mw-wikilove-commons-text' )
249252 .toggle( $.inArray( 'image', currentTypeOrSubtype.fields ) >= 0 );
250253
251254 // set the new text for the image textbox
Index: trunk/extensions/WikiLove/WikiLove.i18n.php
@@ -24,7 +24,7 @@
2525 'wikilove-get-started-list-2' => 'Add details to your WikiLove',
2626 'wikilove-get-started-list-3' => 'Send your WikiLove!',
2727 'wikilove-add-details' => 'Add details',
28 - 'wikilove-image' => 'Enter an image from Wikimedia Commons:',
 28+ 'wikilove-image' => 'Enter an image filename:',
2929 'wikilove-select-image' => 'Select an image:',
3030 'wikilove-header' => 'Enter a header:',
3131 'wikilove-title' => 'Enter a title:',
@@ -48,6 +48,9 @@
4949 'wikilove-summary' => '/* $1 */ new WikiLove message',
5050 'wikilove-what-is-this' => "What is this?",
5151 'wikilove-anon-warning' => 'Note: This user is not registered, he or she many not notice this message.',
 52+ 'wikilove-commons-text' => 'You can find images by browsing $1.',
 53+ 'wikilove-commons-link' => 'Wikimedia Commons',
 54+ 'wikilove-commons-url' => 'http://commons.wikimedia.org',
5255 );
5356
5457 /** Message documentation (Message documentation)
@@ -58,6 +61,7 @@
5962 'wikilove-preview' => 'Title. Noun.',
6063 'wikilove-barnstar-header' => 'See [[:wikipedia:Barnstar]]. Probably not literally translatable.',
6164 'wikilove-image-example' => 'The filename should be an actual image on Wikimedia Commons.',
 65+ 'wikilove-commons-text' => '$1 gets replaced by a link with wikilove-commons-link as caption and wikilove-commons-url as URL',
6266 );
6367
6468 /** Bulgarian (Български)

Follow-up revisions

RevisionCommit summaryAuthorDate
r90967Followup r90958 for Translatewikiraymond15:07, 28 June 2011
r90975Followup r90958 for Translatewiki and fix for r90967 per JanPaul's CE:...raymond16:01, 28 June 2011

Status & tagging log