r83789 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83788‎ | r83789 | r83790 >
Date:22:42, 12 March 2011
Author:happy-melon
Status:ok (Comments)
Tags:
Comment:
Spin out all the CSS used on special pages into their own mediawiki.special module. This comprises about a third of /skins/common/shared.css, so it's definitely worthwhile not loading it for the 99.9% of pageviews which aren't special pages.
Modified paths:
  • /trunk/extensions/AdminLinks/AdminLinks_body.php (modified) (history)
  • /trunk/extensions/CentralAuth/SpecialGlobalGroupMembership.php (modified) (history)
  • /trunk/extensions/ReplaceText/SpecialReplaceText.php (modified) (history)
  • /trunk/extensions/SharedUserRights/SharedUserRights_body.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialAllmessages.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialAllpages.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialBlock.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialEmailuser.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialListgrouprights.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialPrefixindex.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialSpecialpages.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialStatistics.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUserrights.php (modified) (history)
  • /trunk/phase3/resources/Resources.php (modified) (history)
  • /trunk/phase3/resources/mediawiki.special/mediawiki.special.css (added) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -11,7 +11,9 @@
1212
1313 /* Links to redirects appear italicized on [[Special:AllPages]], [[Special:PrefixIndex]],
1414 [[Special:Watchlist/edit]] and in category listings */
15 -.allpagesredirect, .redirect-in-category, .watchlistredir { font-style: italic; }
 15+.allpagesredirect, .redirect-in-category, .watchlistredir {
 16+ font-style: italic;
 17+}
1618
1719 /* Comment and username portions of RC entries */
1820 span.comment {
@@ -145,214 +147,7 @@
146148 float: right;
147149 }
148150
149 -/* Search results */
150 -.searchresults {
151 -}
152 -
153 -.searchresults p {
154 - margin-left: 0.4em;
155 - margin-top: 1em;
156 - margin-bottom: 1.2em;
157 -}
158 -
159 -div.searchresult {
160 - font-size: 95%;
161 - width: 38em;
162 -}
163 -
164 -.mw-search-results {
165 - margin-left: 0.4em;
166 -}
167 -
168 -.mw-search-results li {
169 - padding-bottom: 1em;
170 - list-style: none;
171 - list-style-image: none;
172 -}
173 -.mw-search-results li a {
174 - font-size: 108%;
175 -}
176 -
177 -.mw-search-result-data {
178 - color: green;
179 - font-size: 97%;
180 -}
181 -
182 -.mw-search-formheader {
183 - background-color: #f3f3f3;
184 - margin-top: 1em;
185 - border: 1px solid silver;
186 -}
187 -.mw-search-formheader div.search-types {
188 - float: left;
189 - padding-left: 0.25em;
190 -}
191 -.mw-search-formheader div.search-types ul {
192 - margin: 0 !important;
193 - padding: 0 !important;
194 - list-style: none !important;
195 -}
196 -.mw-search-formheader div.search-types ul li {
197 - float: left;
198 - margin: 0;
199 - padding: 0;
200 -}
201 -.mw-search-formheader div.search-types ul li a {
202 - display: block;
203 - padding: 0.5em;
204 -}
205 -.mw-search-formheader div.search-types ul li.current a {
206 - color: #333333;
207 - cursor: default;
208 -}
209 -.mw-search-formheader div.search-types ul li.current a:hover {
210 - text-decoration: none;
211 -}
212 -.mw-search-formheader div.results-info {
213 - float: right;
214 - padding: 0.5em;
215 - padding-right: 0.75em;
216 -}
217 -.mw-search-formheader div.results-info ul {
218 - margin: 0 !important;
219 - padding: 0 !important;
220 - list-style: none !important;
221 -}
222 -.mw-search-formheader div.results-info ul li {
223 - float: right;
224 - margin: 0;
225 - padding: 0;
226 -}
227 -fieldset#mw-searchoptions {
228 - margin: 0;
229 - padding-left: 0.75em !important;
230 - padding-right: 0.75em !important;
231 - padding-bottom: 0.5em !important;
232 - padding-top: 0.5em !important;
233 - border: none;
234 - background-color: #f9f9f9;
235 - border: 1px solid silver !important;
236 - border-top-width: 0 !important;
237 -}
238 -fieldset#mw-searchoptions legend {
239 - display: none;
240 -}
241 -fieldset#mw-searchoptions h4 {
242 - padding: 0;
243 - margin: 0;
244 - float: left;
245 -}
246 -fieldset#mw-searchoptions div#mw-search-togglebox {
247 - float: right;
248 -}
249 -
250 -fieldset#mw-searchoptions div#mw-search-togglebox label {
251 - margin-right: 0.25em;
252 -}
253 -fieldset#mw-searchoptions div#mw-search-togglebox input {
254 - margin-left: 0.25em;
255 -}
256 -fieldset#mw-searchoptions table {
257 - float: left;
258 - margin-right: 3em;
259 -}
260 -fieldset#mw-searchoptions table td {
261 - padding-right: 1em;
262 -}
263 -fieldset#mw-searchoptions div.divider {
264 - clear: both;
265 - border-bottom: 1px solid #DDDDDD;
266 - padding-top: 0.5em;
267 - margin-bottom: 0.5em;
268 -}
269 -
270 -td#mw-search-menu {
271 - padding-left:6em;
272 - font-size:85%;
273 -}
274 -
275 -div#mw-search-interwiki {
276 - float: right;
277 - width: 18em;
278 - border-style: solid;
279 - border-color: #AAAAAA;
280 - border-width: 1px;
281 - margin-top: 2ex;
282 -}
283 -
284 -div#mw-search-interwiki li {
285 - font-size: 95%;
286 -}
287 -
288 -.mw-search-interwiki-more {
289 - float: right;
290 - font-size: 90%;
291 -}
292 -
293 -div#mw-search-interwiki-caption {
294 - text-align: center;
295 - font-weight: bold;
296 - font-size: 95%;
297 -}
298 -
299 -.mw-search-interwiki-project {
300 - font-size: 97%;
301 - text-align: left;
302 - padding-left: 0.2em;
303 - padding-right: 0.15em;
304 - padding-bottom: 0.2em;
305 - padding-top: 0.15em;
306 - background-color: #ececec;
307 - border-top: 1px solid #BBBBBB;
308 -}
309 -
310 -span.searchalttitle {
311 - font-size: 95%;
312 -}
313 -
314 -div.searchdidyoumean {
315 - font-size: 127%;
316 - margin-top: 0.8em;
317 - /* Note that this color won't affect the link, as desired. */
318 - color: #c00;
319 -}
320 -
321 -div.searchdidyoumean em {
322 - font-weight: bold;
323 -}
324 -
325 -.searchmatch {
326 - font-weight: bold;
327 -}
328 -
329 -
330151 /*
331 - * Advanced PowerSearch box
332 - */
333 -td#mw-search-togglebox {
334 - text-align: right;
335 -}
336 -
337 -table#mw-search-powertable {
338 - width: 100%;
339 -}
340 -
341 -form#powersearch {
342 - clear: both;
343 -}
344 -
345 -/*
346 - * UserRights stuff
347 - */
348 -.mw-userrights-disabled {
349 - color: #888;
350 -}
351 -
352 -table.mw-userrights-groups * td,table.mw-userrights-groups * th {
353 - padding-right: 1.5em;
354 -}
355 -
356 -/*
357152 * OpenSearch ajax suggestions
358153 */
359154 .os-suggest {
@@ -435,73 +230,10 @@
436231 font-weight: bold;
437232 }
438233
439 -/* Special:Contributions styling */
440 -.mw-uctop {
441 - font-weight: bold;
442 -}
443 -
444 -/* Special:ListGroupRights styling */
445 -table.mw-listgrouprights-table tr {
446 - vertical-align: top;
447 -}
448 -.listgrouprights-revoked {
449 - text-decoration: line-through;
450 -}
451 -
452 -/* Special:Statistics styling */
453 -td.mw-statistics-numbers {
454 - text-align: right;
455 -}
456 -
457234 #shared-image-dup, #shared-image-conflict {
458235 font-style: italic;
459236 }
460237
461 -/* Special:EmailUser styling */
462 -table.mw-emailuser-table {
463 - width: 98%;
464 -}
465 -td#mw-emailuser-sender, td#mw-emailuser-recipient {
466 - font-weight: bold;
467 -}
468 -
469 -/* Special:Allpages styling */
470 -table.mw-allpages-table-form, table.mw-allpages-table-chunk {
471 - width: 100%;
472 -}
473 -td.mw-allpages-alphaindexline {
474 - text-align: right;
475 -}
476 -td.mw-allpages-nav, p.mw-allpages-nav {
477 - text-align: right;
478 - font-size: smaller;
479 - margin-bottom: 1em;
480 -}
481 -table.mw-allpages-table-form tr {
482 - vertical-align: top;
483 -}
484 -
485 -/* Special:Prefixindex styling */
486 -table#mw-prefixindex-list-table,
487 -table#mw-prefixindex-nav-table {
488 - width: 98%;
489 -}
490 -td#mw-prefixindex-nav-form {
491 - font-size: smaller;
492 - margin-bottom: 1em;
493 - text-align: right;
494 - vertical-align: top;
495 -}
496 -
497 -/* Special:Specialpages style */
498 -.mw-specialpagecached{
499 - font-style:italic;
500 -}
501 -
502 -.mw-specialpagerestricted{
503 - font-weight:bold;
504 -}
505 -
506238 /*
507239 * Recreating deleted page warning
508240 * Reupload file warning
@@ -669,23 +401,6 @@
670402 background-color: #ccccff;
671403 }
672404
673 -/* Allmessages table */
674 -#mw-allmessagestable .allmessages-customised td.am_default {
675 - background-color: #fcffc4;
676 -}
677 -
678 -#mw-allmessagestable tr.allmessages-customised:hover td.am_default {
679 - background-color: #faff90;
680 -}
681 -
682 -#mw-allmessagestable td.am_actual {
683 - background-color: #e2ffe2;
684 -}
685 -
686 -#mw-allmessagestable tr.allmessages-customised:hover + tr.allmessages-customised td.am_actual {
687 - background-color: #b1ffb1;
688 -}
689 -
690405 /* filetoc */
691406 ul#filetoc {
692407 text-align: center;
Index: trunk/phase3/includes/specials/SpecialAllpages.php
@@ -76,6 +76,7 @@
7777 wfMsg( 'allinnamespace', str_replace( '_', ' ', $namespaces[$namespace] ) ) :
7878 wfMsg( 'allarticles' )
7979 );
 80+ $wgOut->addModuleStyles( 'mediawiki.special' );
8081
8182 if( isset($par) ) {
8283 $this->showChunk( $namespace, $par, $to );
Index: trunk/phase3/includes/specials/SpecialUserrights.php
@@ -112,7 +112,7 @@
113113 }
114114
115115 $this->outputHeader();
116 -
 116+ $wgOut->addModuleStyles( 'mediawiki.special' );
117117 $this->setHeaders();
118118
119119 // show the general form
Index: trunk/phase3/includes/specials/SpecialAllmessages.php
@@ -59,6 +59,8 @@
6060 $this->outputHeader( 'allmessagestext' );
6161 }
6262
 63+ $wgOut->addModuleStyles( 'mediawiki.special' );
 64+
6365 $this->filter = $wgRequest->getVal( 'filter', 'all' );
6466 $this->prefix = $wgRequest->getVal( 'prefix', '' );
6567
Index: trunk/phase3/includes/specials/SpecialStatistics.php
@@ -41,6 +41,7 @@
4242 global $wgDisableCounters, $wgMiserMode;
4343
4444 $this->setHeaders();
 45+ $wgOut->addModuleStyles( 'mediawiki.special' );
4546
4647 $this->views = SiteStats::views();
4748 $this->edits = SiteStats::edits();
Index: trunk/phase3/includes/specials/SpecialSpecialpages.php
@@ -37,6 +37,7 @@
3838 $this->setHeaders();
3939 $this->outputHeader();
4040 $wgOut->allowClickjacking();
 41+ $wgOut->addModuleStyles( 'mediawiki.special' );
4142
4243 $groups = $this->getPageGroups();
4344
Index: trunk/phase3/includes/specials/SpecialPrefixindex.php
@@ -42,6 +42,7 @@
4343
4444 $this->setHeaders();
4545 $this->outputHeader();
 46+ $wgOut->addModuleStyles( 'mediawiki.special' );
4647
4748 # GET values
4849 $from = $wgRequest->getVal( 'from', '' );
Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -40,6 +40,7 @@
4141
4242 $this->setHeaders();
4343 $this->outputHeader();
 44+ $wgOut->addModuleStyles( 'mediawiki.special' );
4445
4546 $this->opts = array();
4647
Index: trunk/phase3/includes/specials/SpecialListgrouprights.php
@@ -51,6 +51,7 @@
5252
5353 $this->setHeaders();
5454 $this->outputHeader();
 55+ $wgOut->addModuleStyles( 'mediawiki.special' );
5556
5657 $wgOut->addHTML(
5758 Xml::openElement( 'table', array( 'class' => 'wikitable mw-listgrouprights-table' ) ) .
Index: trunk/phase3/includes/specials/SpecialBlock.php
@@ -78,7 +78,7 @@
7979 }
8080
8181 $wgOut->setPageTitle( wfMsg( 'blockip-title' ) );
82 - $wgOut->addModules( 'mediawiki.special.block' );
 82+ $wgOut->addModules( 'mediawiki.special', 'mediawiki.special.block' );
8383
8484 $fields = self::getFormFields();
8585 $this->alreadyBlocked = $this->maybeAlterFormDefaults( $fields );
Index: trunk/phase3/includes/specials/SpecialSearch.php
@@ -44,6 +44,7 @@
4545 $this->setHeaders();
4646 $this->outputHeader();
4747 $wgOut->allowClickjacking();
 48+ $wgOut->addModuleStyles( 'mediawiki.special' );
4849
4950 // Strip underscores from title parameter; most of the time we'll want
5051 // text form here. But don't strip underscores from actual text params!
Index: trunk/phase3/includes/specials/SpecialEmailuser.php
@@ -88,6 +88,7 @@
8989
9090 $this->setHeaders();
9191 $this->outputHeader();
 92+ $wgOut->addModuleStyles( 'mediawiki.special' );
9293
9394 $this->mTarget = is_null( $par )
9495 ? $wgRequest->getVal( 'wpTarget', $wgRequest->getVal( 'target', '' ) )
Index: trunk/phase3/resources/Resources.php
@@ -416,6 +416,12 @@
417417 'scripts' => 'resources/mediawiki.action/mediawiki.action.watch.ajax.js',
418418 'dependencies' => 'mediawiki.util',
419419 ),
 420+
 421+ /* Special pages */
 422+
 423+ 'mediawiki.special' => array(
 424+ 'styles' => 'resources/mediawiki.special/mediawiki.special.css',
 425+ ),
420426 'mediawiki.special.preferences' => array(
421427 'scripts' => 'resources/mediawiki.special/mediawiki.special.preferences.js',
422428 'styles' => 'resources/mediawiki.special/mediawiki.special.preferences.css',
@@ -444,6 +450,7 @@
445451 ),
446452 'dependencies' => array( 'mediawiki.util.jpegmeta' ),
447453 ),
 454+
448455 'mediawiki.language' => array(
449456 'scripts' => 'resources/mediawiki.language/mediawiki.language.js',
450457 'languageScripts' => array(
Index: trunk/phase3/resources/mediawiki.special/mediawiki.special.css
@@ -0,0 +1,262 @@
 2+
 3+/**** Special:AllMessages ****/
 4+#mw-allmessagestable .allmessages-customised td.am_default {
 5+ background-color: #fcffc4;
 6+}
 7+
 8+#mw-allmessagestable tr.allmessages-customised:hover td.am_default {
 9+ background-color: #faff90;
 10+}
 11+
 12+#mw-allmessagestable td.am_actual {
 13+ background-color: #e2ffe2;
 14+}
 15+
 16+#mw-allmessagestable tr.allmessages-customised:hover + tr.allmessages-customised td.am_actual {
 17+ background-color: #b1ffb1;
 18+}
 19+
 20+/**** Special:Allpages ****/
 21+table.mw-allpages-table-form, table.mw-allpages-table-chunk {
 22+ width: 100%;
 23+}
 24+td.mw-allpages-alphaindexline {
 25+ text-align: right;
 26+}
 27+td.mw-allpages-nav, p.mw-allpages-nav {
 28+ text-align: right;
 29+ font-size: smaller;
 30+ margin-bottom: 1em;
 31+}
 32+table.mw-allpages-table-form tr {
 33+ vertical-align: top;
 34+}
 35+
 36+/**** Special:Block ****/
 37+tr.mw-block-hideuser {
 38+ font-weight: bold;
 39+}
 40+
 41+/**** Special:Contributions ****/
 42+.mw-uctop {
 43+ font-weight: bold;
 44+}
 45+
 46+/**** Special:EmailUser ****/
 47+table.mw-emailuser-table {
 48+ width: 98%;
 49+}
 50+td#mw-emailuser-sender,
 51+td#mw-emailuser-recipient {
 52+ font-weight: bold;
 53+}
 54+
 55+/**** Special:ListGroupRights ****/
 56+table.mw-listgrouprights-table tr {
 57+ vertical-align: top;
 58+}
 59+.listgrouprights-revoked {
 60+ text-decoration: line-through;
 61+}
 62+
 63+/**** Special:Prefixindex ****/
 64+table#mw-prefixindex-list-table,
 65+table#mw-prefixindex-nav-table {
 66+ width: 98%;
 67+}
 68+td#mw-prefixindex-nav-form {
 69+ font-size: smaller;
 70+ margin-bottom: 1em;
 71+ text-align: right;
 72+ vertical-align: top;
 73+}
 74+
 75+
 76+/**** Special:Search ****/
 77+.searchresults {
 78+}
 79+
 80+.searchresults p {
 81+ margin-left: 0.4em;
 82+ margin-top: 1em;
 83+ margin-bottom: 1.2em;
 84+}
 85+div.searchresult {
 86+ font-size: 95%;
 87+ width: 38em;
 88+}
 89+.mw-search-results {
 90+ margin-left: 0.4em;
 91+}
 92+.mw-search-results li {
 93+ padding-bottom: 1em;
 94+ list-style: none;
 95+ list-style-image: none;
 96+}
 97+.mw-search-results li a {
 98+ font-size: 108%;
 99+}
 100+.mw-search-result-data {
 101+ color: green;
 102+ font-size: 97%;
 103+}
 104+.mw-search-formheader {
 105+ background-color: #f3f3f3;
 106+ margin-top: 1em;
 107+ border: 1px solid silver;
 108+}
 109+.mw-search-formheader div.search-types {
 110+ float: left;
 111+ padding-left: 0.25em;
 112+}
 113+.mw-search-formheader div.search-types ul {
 114+ margin: 0 !important;
 115+ padding: 0 !important;
 116+ list-style: none !important;
 117+}
 118+.mw-search-formheader div.search-types ul li {
 119+ float: left;
 120+ margin: 0;
 121+ padding: 0;
 122+}
 123+.mw-search-formheader div.search-types ul li a {
 124+ display: block;
 125+ padding: 0.5em;
 126+}
 127+.mw-search-formheader div.search-types ul li.current a {
 128+ color: #333333;
 129+ cursor: default;
 130+}
 131+.mw-search-formheader div.search-types ul li.current a:hover {
 132+ text-decoration: none;
 133+}
 134+.mw-search-formheader div.results-info {
 135+ float: right;
 136+ padding: 0.5em;
 137+ padding-right: 0.75em;
 138+}
 139+.mw-search-formheader div.results-info ul {
 140+ margin: 0 !important;
 141+ padding: 0 !important;
 142+ list-style: none !important;
 143+}
 144+.mw-search-formheader div.results-info ul li {
 145+ float: right;
 146+ margin: 0;
 147+ padding: 0;
 148+}
 149+fieldset#mw-searchoptions {
 150+ margin: 0;
 151+ padding: 0.5em 0.75em 0.75em 0.75em !important;
 152+ border: none;
 153+ background-color: #f9f9f9;
 154+ border: 1px solid silver !important;
 155+ border-top-width: 0 !important;
 156+}
 157+fieldset#mw-searchoptions legend {
 158+ display: none;
 159+}
 160+fieldset#mw-searchoptions h4 {
 161+ padding: 0;
 162+ margin: 0;
 163+ float: left;
 164+}
 165+fieldset#mw-searchoptions div#mw-search-togglebox {
 166+ float: right;
 167+}
 168+fieldset#mw-searchoptions div#mw-search-togglebox label {
 169+ margin-right: 0.25em;
 170+}
 171+fieldset#mw-searchoptions div#mw-search-togglebox input {
 172+ margin-left: 0.25em;
 173+}
 174+fieldset#mw-searchoptions table {
 175+ float: left;
 176+ margin-right: 3em;
 177+}
 178+fieldset#mw-searchoptions table td {
 179+ padding-right: 1em;
 180+}
 181+fieldset#mw-searchoptions div.divider {
 182+ clear: both;
 183+ border-bottom: 1px solid #DDDDDD;
 184+ padding-top: 0.5em;
 185+ margin-bottom: 0.5em;
 186+}
 187+td#mw-search-menu {
 188+ padding-left:6em;
 189+ font-size:85%;
 190+}
 191+div#mw-search-interwiki {
 192+ float: right;
 193+ width: 18em;
 194+ border: 1px solid #AAAAAA;
 195+ margin-top: 2ex;
 196+}
 197+div#mw-search-interwiki li {
 198+ font-size: 95%;
 199+}
 200+.mw-search-interwiki-more {
 201+ float: right;
 202+ font-size: 90%;
 203+}
 204+div#mw-search-interwiki-caption {
 205+ text-align: center;
 206+ font-weight: bold;
 207+ font-size: 95%;
 208+}
 209+.mw-search-interwiki-project {
 210+ font-size: 97%;
 211+ text-align: left;
 212+ padding: 0.15em 0.15em 0.2em 0.2em;
 213+ background-color: #ececec;
 214+ border-top: 1px solid #BBBBBB;
 215+}
 216+span.searchalttitle {
 217+ font-size: 95%;
 218+}
 219+div.searchdidyoumean {
 220+ font-size: 127%;
 221+ margin-top: 0.8em;
 222+ /* Note that this color won't affect the link, as desired. */
 223+ color: #c00;
 224+}
 225+div.searchdidyoumean em {
 226+ font-weight: bold;
 227+}
 228+.searchmatch {
 229+ font-weight: bold;
 230+}
 231+/* Advanced PowerSearch box */
 232+td#mw-search-togglebox {
 233+ text-align: right;
 234+}
 235+table#mw-search-powertable {
 236+ width: 100%;
 237+}
 238+form#powersearch {
 239+ clear: both;
 240+}
 241+
 242+/**** Special:Specialpages ****/
 243+.mw-specialpagecached {
 244+ font-style:italic;
 245+}
 246+.mw-specialpagerestricted {
 247+ font-weight:bold;
 248+}
 249+
 250+
 251+/**** Special:Statistics ****/
 252+td.mw-statistics-numbers {
 253+ text-align: right;
 254+}
 255+
 256+/**** Special:UserRights ****/
 257+.mw-userrights-disabled {
 258+ color: #888;
 259+}
 260+table.mw-userrights-groups * td,
 261+table.mw-userrights-groups * th {
 262+ padding-right: 1.5em;
 263+}
\ No newline at end of file
Property changes on: trunk/phase3/resources/mediawiki.special/mediawiki.special.css
___________________________________________________________________
Added: svn:eol-style
1264 + native
Index: trunk/extensions/CentralAuth/SpecialGlobalGroupMembership.php
@@ -37,6 +37,7 @@
3838 $selector->addOption( $wiki );
3939 }
4040
 41+ $wgOut->addModuleStyles( 'mediawiki.special' );
4142 $wgOut->addHTML(
4243 Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript, 'name' => 'uluser', 'id' => 'mw-userrights-form1' ) ) .
4344 Html::hidden( 'title', $this->getTitle() ) .
Index: trunk/extensions/AdminLinks/AdminLinks_body.php
@@ -77,6 +77,7 @@
7878 $admin_links_tree = $this->createInitialTree();
7979 wfRunHooks( 'AdminLinks', array( &$admin_links_tree ) );
8080 global $wgOut;
 81+ $wgOut->addModuleStyles( 'mediawiki.special' );
8182 $wgOut->addHTML( $admin_links_tree->toString() );
8283 }
8384
Index: trunk/extensions/ReplaceText/SpecialReplaceText.php
@@ -23,6 +23,7 @@
2424
2525 $this->user = $wgUser;
2626 $this->setHeaders();
 27+ $wgOut->addModuleStyles( 'mediawiki.special' );
2728 $this->doSpecialReplaceText();
2829 }
2930
Index: trunk/extensions/SharedUserRights/SharedUserRights_body.php
@@ -60,7 +60,7 @@
6161 }
6262
6363 $this->outputHeader();
64 -
 64+ $wgOut->addModuleStyles( 'mediawiki.special' );
6565 $this->setHeaders();
6666
6767 # show user selection form

Sign-offs

UserFlagDate
Nikerabbitinspected08:47, 13 March 2011
Hasharinspected18:41, 13 March 2011
Krinkleinspected23:58, 1 June 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r84176Fix for loading a module in MW 1.17 - follow-up to r84165 and r83789yaron16:06, 17 March 2011
r85055Follow-up to r83789 - added backward-compatibility to $wgOut->addModuleStyles...yaron03:01, 31 March 2011
r90960Fix r90943: redefined mediawiki.special module that had already been added in...catrope14:28, 28 June 2011
r98185Remove italic styling for .mw-specialpagecached (See r83554 CR)...krinkle22:13, 26 September 2011

Comments

#Comment by Hashar (talk | contribs)   18:41, 13 March 2011

happy-melon, saving WMF bandwidth since 2011 =)

#Comment by Dantman (talk | contribs)   04:21, 3 April 2011

The special page styling for Special:SpecialPages is not loading anymore in trunk (the grey header bgs are gone).

#Comment by Happy-melon (talk | contribs)   10:27, 3 April 2011

That was a deliberate change in r82948.

Status & tagging log