r90911 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90910‎ | r90911 | r90912 >
Date:21:48, 27 June 2011
Author:reedy
Status:deferred (Comments)
Tags:
Comment:
Fix get/set accessors from request context stuffs
Modified paths:
  • /trunk/extensions/StyleGuideDemo/HTMLStyleForm.php (modified) (history)

Diff [purge]

Index: trunk/extensions/StyleGuideDemo/HTMLStyleForm.php
@@ -534,7 +534,7 @@
535535 ), $errorstr );
536536 return Html::rawElement( 'div', array(
537537 'class' => 'mw-htmlform-errors'
538 - ), $errorTitle . $errorContent );
 538+ ), $errorTitle . $errorContent );
539539 } else {
540540 return '';
541541 }
@@ -638,7 +638,7 @@
639639 */
640640 function getTitle() {
641641 return $this->mTitle === false
642 - ? $this->getContext()->title
 642+ ? $this->getContext()->getTitle()
643643 : $this->mTitle;
644644 }
645645
@@ -655,21 +655,21 @@
656656 * @return OutputPage
657657 */
658658 public function getOutput(){
659 - return $this->getContext()->output;
 659+ return $this->getContext()->getOutput();
660660 }
661661
662662 /**
663663 * @return WebRequest
664664 */
665665 public function getRequest(){
666 - return $this->getContext()->request;
 666+ return $this->getContext()->getRequest();
667667 }
668668
669669 /**
670670 * @return User
671671 */
672672 public function getUser(){
673 - return $this->getContext()->user;
 673+ return $this->getContext()->getUser();
674674 }
675675
676676 /**

Comments

#Comment by Krinkle (talk | contribs)   22:00, 27 June 2011

Changes to context were made in r90899.

Status & tagging log