r90910 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90909‎ | r90910 | r90911 >
Date:21:43, 27 June 2011
Author:reedy
Status:ok
Tags:
Comment:
* (bug 29597) Add button to browse to the next unresolved revision

Apply patch by Krinkle
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -128,6 +128,8 @@
129129 'code-rev-submit-accesskey' => 's',
130130 'code-rev-submit-next' => 'Save & next unresolved',
131131 'code-rev-submit-next-accesskey' => '',
 132+ 'code-rev-next' => 'Next unresolved',
 133+ 'code-rev-next-accesskey' => '',
132134 'code-batch-status' => 'Change status:',
133135 'code-batch-tags' => 'Change tags:',
134136 'codereview-batch-title' => 'Change all selected revisions',
@@ -311,6 +313,7 @@
312314 'code-rev-submit' => 'Caption of the button used to Save changes when viewing a revision.
313315 {{Identical|Save changes}}',
314316 'code-rev-submit-next' => 'Caption of the button used when viewing a revision to Save changes moving to next unresolved revision.',
 317+ 'code-rev-next' => 'Caption of the button used when viewing a revision to move to the next unresolved revision.',
315318 'codereview-batch-submit' => '{{Identical|Submit}}',
316319 'codereview-subtitle' => '{{Identical|For $1}}
317320 ----
Index: trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php
@@ -29,7 +29,7 @@
3030
3131 // Return to rev page
3232 if ( !$redirTarget ) {
33 - // Was "next & unresolved" clicked?
 33+ // Was "next" (or "save & next") clicked?
3434 if ( $this->jumpToNext ) {
3535 $next = $this->mRev->getNextUnresolved( $this->mPath );
3636 if ( $next ) {
Index: trunk/extensions/CodeReview/ui/CodeRevisionView.php
@@ -34,7 +34,7 @@
3535 $this->mAddTags = $wgRequest->getText( 'wpTag' );
3636 $this->mRemoveTags = $wgRequest->getText( 'wpRemoveTag' );
3737 $this->mStatus = $wgRequest->getText( 'wpStatus' );
38 - $this->jumpToNext = $wgRequest->getCheck( 'wpSaveAndNext' );
 38+ $this->jumpToNext = $wgRequest->getCheck( 'wpSaveAndNext' ) || $wgRequest->getCheck( 'wpNext' );
3939 $this->mReplyTarget = $replyTarget ?
4040 (int)$replyTarget : $wgRequest->getIntOrNull( 'wpParent' );
4141 $this->text = $wgRequest->getText( "wpReply{$this->mReplyTarget}" );
@@ -905,6 +905,10 @@
906906 array( 'name' => 'wpSaveAndNext',
907907 'accesskey' => wfMsg( 'code-rev-submit-next-accesskey' ) )
908908 ) . ' ' .
 909+ Xml::submitButton( wfMsg( 'code-rev-next' ),
 910+ array( 'name' => 'wpNext',
 911+ 'accesskey' => wfMsg( 'code-rev-next-accesskey' ) )
 912+ ) . ' ' .
909913 Xml::submitButton( wfMsg( 'code-rev-comment-preview' ),
910914 array( 'name' => 'wpPreview',
911915 'accesskey' => wfMsg( 'code-rev-comment-preview-accesskey' ) )

Follow-up revisions

RevisionCommit summaryAuthorDate
r90952Followup r90910 for Translatewikiraymond12:51, 28 June 2011

Status & tagging log