r90912 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90911‎ | r90912 | r90913 >
Date:21:56, 27 June 2011
Author:krinkle
Status:deferred
Tags:
Comment:
StyleGuideDemo
Continue implementation of the style guide for forms:
- Green is for special buttons, not hover state
- no hover state
- active state (mousedown) is reversed gradient


(r90908, r90909)
Modified paths:
  • /trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/ext.styleguidedemo.css (modified) (history)
  • /trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/images/MW-StyleGuide-Form-Button-BGShadeActive.png (deleted) (history)
  • /trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/images/MW-StyleGuide-Form-Button-BGShadeHover.png (deleted) (history)
  • /trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/images/MW-StyleGuide-Form-Button-BGShadeSpecial.png (added) (history)
  • /trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/images/MW-StyleGuide-Form-Button-BGShadeSpecialActive.png (added) (history)

Diff [purge]

Index: trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/images/MW-StyleGuide-Form-Button-BGShadeActive.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/images/MW-StyleGuide-Form-Button-BGShadeHover.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/images/MW-StyleGuide-Form-Button-BGShadeSpecialActive.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/images/MW-StyleGuide-Form-Button-BGShadeSpecialActive.png
___________________________________________________________________
Added: svn:mime-type
11 + image/png
Index: trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/images/MW-StyleGuide-Form-Button-BGShadeSpecial.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/images/MW-StyleGuide-Form-Button-BGShadeSpecial.png
___________________________________________________________________
Added: svn:mime-type
22 + image/png
Index: trunk/extensions/StyleGuideDemo/modules/ext.styleguidedemo/ext.styleguidedemo.css
@@ -67,12 +67,12 @@
6868 width: 200px; /* width: 214px; */
6969 }
7070
71 -/* no-js */
 71+/* Buttons (no-js) */
7272 .mw-htmlform-submit {
7373 float: right;
7474 }
7575
76 -/* js-only */
 76+/* Buttons (js-only) */
7777 .mw-htmlform-button,
7878 .mw-htmlform-button-wrap {
7979 -webkit-border-radius: 4px;
@@ -83,6 +83,7 @@
8484 float: right;
8585 border: 1px solid #9d9d9d;
8686 }
 87+
8788 .mw-htmlform-button {
8889 padding: 5px 10px;
8990 background: #edecef url(images/MW-StyleGuide-Form-Button-BGShade.png) center center repeat-x;
@@ -91,13 +92,18 @@
9293 font-weight: bold;
9394 color: #6c6c6c;
9495 }
95 -
9696 .mw-htmlform-button:hover {
9797 cursor: pointer;
98 - background: #3cb878 url(images/MW-StyleGuide-Form-Button-BGShadeHover.png) center center repeat-x;
99 - color: #ffffff;
100 - border-color: #5ac084;
10198 }
10299 .mw-htmlform-button:active {
103100 background-image: url(images/MW-StyleGuide-Form-Button-BGShadeActive.png);
104101 }
 102+
 103+.mw-htmlform-button-special {
 104+ background: #3cb878 url(images/MW-StyleGuide-Form-Button-BGShadeSpecial.png) center center repeat-x;
 105+ color: #ffffff;
 106+ border-color: #5ac084;
 107+}
 108+.mw-htmlform-button-special:active {
 109+ background-image: url(images/MW-StyleGuide-Form-Button-BGShadeSpecialActive.png);
 110+}

Follow-up revisions

RevisionCommit summaryAuthorDate
r90914StyleGuideDemo...krinkle22:19, 27 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90908StyleGuideDemo...krinkle21:21, 27 June 2011
r90909images! FolUp r90908krinkle21:31, 27 June 2011

Status & tagging log