r90530 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r90529‎ | r90530 | r90531 >
Date:15:06, 21 June 2011
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Revert r90483, if tesla has problems, it should get proper permissions to the affected folders (or change the test to use a temp folder)
The test was not consistent, since first time it would use the svn file, which renames it... and on next run it would be missing!
I added the '.' to the unlik() step so it properly cleans up. Opened bug 29512 for the strange UploadStash behavior.

However, although it passes now most of the times, it sometimes fails with the strange exception:
Only variables should be passed by reference

phase3/includes/upload/UploadStash.php:143
phase3/tests/phpunit/includes/upload/UploadStashTest.php:22
phase3/tests/phpunit/MediaWikiTestCase.php:64
phase3/tests/phpunit/MediaWikiPHPUnitCommand.php:20
phase3/tests/phpunit/phpunit.php:60
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/upload/UploadStashTest.php (modified) (history)
  • /trunk/phase3/tests/phpunit/includes/upload/bug29408 (deleted) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/upload/bug29408
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/phase3/tests/phpunit/includes/upload/UploadStashTest.php
——@@ -11,7 +11,7 @@
1212
1313 // Setup a file for bug 29408
1414 $this->bug29408File = dirname( __FILE__ ) . '/bug29408';
15 - // file_put_contents( $this->bug29408File, "\x00" );
 15+ file_put_contents( $this->bug29408File, "\x00" );
1616 }
1717
1818 public function testBug29408() {
——@@ -28,5 +28,8 @@
2929
3030 public function tearDown() {
3131 parent::tearDown();
 32+
 33+ unlink( $this->bug29408File . "." );
 34+
3235 }
33 -}
\ No newline at end of file
 36+}

Follow-up revisions

RevisionCommit summaryAuthorDate
r90531Follow up with the problem noted in r90530....platonides15:13, 21 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90349Follow-up r90340: just add the test file to SVN, which hopefully fixes the cr...btongminh17:27, 18 June 2011

Comments

#Comment by Platonides (talk | contribs)   15:10, 21 June 2011

This should read 'Revert r90349'

Status & tagging log