r90286 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r90285‎ | r90286 | r90287 >
Date:16:26, 17 June 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Swap else if for elseif

Trimming trailing whitespace also
Modified paths:
  • /trunk/extensions/DeleteBatch/DeleteBatch.body.php (modified) (history)
  • /trunk/extensions/Deployment/includes/pclzip.lib.php (modified) (history)
  • /trunk/extensions/Description/Description.php (modified) (history)
  • /trunk/extensions/DiscussionThreading/DiscussionThreading.php (modified) (history)
  • /trunk/extensions/DonationInterface/activemq_stomp/Stomp.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/ccfd/CreditCardFraudDetection.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/extras/recaptcha/recaptcha-php/recaptchalib.php (modified) (history)
  • /trunk/extensions/DoubleWiki/DoubleWiki_body.php (modified) (history)
  • /trunk/extensions/DynamicSidebar/DynamicSidebar.body.php (modified) (history)
  • /trunk/extensions/EmailPage/PHPMailer_v5.1/class.phpmailer.php (modified) (history)
  • /trunk/extensions/EmailUsers/SpecialEmailUsers.php (modified) (history)
  • /trunk/extensions/EmergencyDeSysop/SpecialEmergencyDeSysop.php (modified) (history)
  • /trunk/extensions/ErrorHandler/ErrorHandler.php (modified) (history)
  • /trunk/extensions/FCKeditor/FCKeditor.body.php (modified) (history)
  • /trunk/extensions/FCKeditor/FCKeditorParser.body.php (modified) (history)
  • /trunk/extensions/FCKeditor/FCKeditorSajax.body.php (modified) (history)
  • /trunk/extensions/FCKeditor/FCKeditorSkin.body.php (modified) (history)
  • /trunk/extensions/Farmer/MediaWikiFarmer_Wiki.php (modified) (history)
  • /trunk/extensions/FirePHP/lib/FirePHP.class.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/api/actions/ApiStabilize.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/business/RevisionReviewForm.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/dataclasses/FlaggedRevs.class.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/dataclasses/FlaggedRevs.hooks.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/presentation/FlaggedPageView.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/presentation/FlaggedRevsUI.hooks.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/presentation/RevisionReviewFormUI.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/presentation/specialpages/reports/UnreviewedPages_body.php (modified) (history)
  • /trunk/extensions/FolkTagCloud/FolkTagCloud.php (modified) (history)
  • /trunk/extensions/ForcePreview/ForcePreview.php (modified) (history)
  • /trunk/extensions/Form/Form.body.php (modified) (history)
  • /trunk/extensions/GlobalUsage/GlobalUsageHooks.php (modified) (history)
  • /trunk/extensions/GoogleMaps/GoogleMaps.body.php (modified) (history)
  • /trunk/extensions/GoogleMaps/export/GoogleMapsJsExporter.php (modified) (history)
  • /trunk/extensions/GoogleMaps/export/GoogleMapsKmlExporter.php (modified) (history)
  • /trunk/extensions/HTMLets/HTMLets.php (modified) (history)
  • /trunk/extensions/HtmlUi/classes/HtmlUiTemplate.php (modified) (history)
  • /trunk/extensions/IMStatus/IMStatus.php (modified) (history)
  • /trunk/extensions/ImageMap/ImageMap_body.php (modified) (history)
  • /trunk/extensions/InlineEditor/ExtendedEditPage.class.php (modified) (history)
  • /trunk/extensions/InlineScripts/interpreter/buildLRTables.php (modified) (history)
  • /trunk/extensions/InputBox/InputBox.classes.php (modified) (history)
  • /trunk/extensions/InspectCache/InspectCache_body.php (modified) (history)
  • /trunk/extensions/Interlanguage/InterlanguageExtension.php (modified) (history)
  • /trunk/extensions/InterwikiIntegration/InterwikiIntegrationChangesList.php (modified) (history)
  • /trunk/extensions/LanguageSelector/LanguageSelector.php (modified) (history)
  • /trunk/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)
  • /trunk/extensions/LiquidThreads/api/ApiQueryLQTThreads.php (modified) (history)
  • /trunk/extensions/LiquidThreads/classes/Dispatch.php (modified) (history)
  • /trunk/extensions/LiquidThreads/classes/NewMessagesController.php (modified) (history)
  • /trunk/extensions/geo/geo.php (modified) (history)

Follow-up revisions

RevisionCommit summaryAuthorDate
r93422Revert r90286 for FCKeditor. I'm not sure why this broke the extension, but i...emufarmers19:54, 28 July 2011
r96107MFT r90286awjrichards15:42, 2 September 2011
r96109MFT r77511, r77805, r90286awjrichards15:53, 2 September 2011
r102236MFT r90286, r100671, r100837, r100950, r101060, r101063, r101064, r101073, r1......khorn03:06, 7 November 2011
r102237MFT r90286, r100671, r100837, r100950, r101060, r101063, r101064, r101073, r1......khorn03:07, 7 November 2011

Comments

#Comment by Krinkle (talk | contribs)   14:53, 13 January 2012

This broke part of JavaScript in /trunk/extensions/FCKeditor/FCKeditor.body.php as it was replacing else if in strings as well, instaed of just the PHP operators. The string in question was JavaScript, which doesn't have elseif.

Status & tagging log