r102237 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102236‎ | r102237 | r102238 >
Date:03:07, 7 November 2011
Author:khorn
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/activemq_stomp/Stomp.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/donationinterface.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/donationinterface_langonly.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/extras (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/extras/conversion_log/conversion_log.body.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/extras/custom_filters/custom_filters.body.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/extras/custom_filters/filters/minfraud/minfraud.body.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/extras/custom_filters/filters/minfraud/minfraud.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/extras/custom_filters/filters/referrer/referrer.body.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/extras/custom_filters/filters/source/source.body.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/extras/minfraud/minfraud.body.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/extras/minfraud/minfraud.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/extras/recaptcha/recaptcha.body.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/DonationData.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/GatewayForm.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/canada-provinces.i18n.php (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/currencyRates.inc (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/donation.api.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/gateway.adapter.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/interface.i18n.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/us-states.i18n.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/Form.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/RapidHtml.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetterCA.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/rapidhtml/RapidHtmlResources.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/rapidhtml/css/webitects.css (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/rapidhtml/css/webitects2nd.css (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/rapidhtml/html/globalcollect_test.html (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/rapidhtml/js/globalcollect_test_2.js (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/TwoStepAmount.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/html/webitects2nd.html (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/html/webitects_2_3step-CA.html (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/html/webitects_2_3step.html (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects.bt.js (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects.js (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects_2_3step.js (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.alias.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.body.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.i18n.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/globalcollect_resultswitcher.body.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/modules/css/style.css (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/modules/js/validate.js (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/form_placeholders.js (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/forms (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/forms/html/webitects_2_3step-CA.html (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/payflowpro.adapter.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.alias.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/validate_input.js (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/tests (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/tests/Adapter/GatewayAdapterTestCase.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/tests/Adapter/GlobalCollect/AllTests.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/tests/Adapter/GlobalCollect/RealTimeBankTransferNordeaSwedenTestCase.php+(from+/trunk/extensions/DonationInterface/tests/Adapter/GlobalCollect/RealTimeBankTransferNordeaSwedenTest (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/tests/DonationInterfaceTestCase.php (modified) (history)

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90286Swap else if for elseif...reedy16:26, 17 June 2011
r100671Simplified validation arrays for payments.jpostlethwaite00:34, 25 October 2011
r100837Adding modules directory for GlobalCollect.jpostlethwaite18:39, 26 October 2011
r100950Adding jquery.validate.js to DonationInterface, under GlobalCollect. This wil...jpostlethwaite06:17, 27 October 2011
r101060Enabling javascript for the module: gc.form.core.validatejpostlethwaite21:30, 27 October 2011
r101063Refactored to work with ResourceLoader module: gc.form.core.validate. See r10...jpostlethwaite21:34, 27 October 2011
r101064Added front end debugging to select form payment types to load. Enabled javas...jpostlethwaite21:37, 27 October 2011
r101073Removed placeholder data from form. Now using gateway adapter methods to pull...jpostlethwaite22:25, 27 October 2011
r101076Do not attempt to create an empty dropdown for issuer_id.jpostlethwaite22:42, 27 October 2011
r101335Adding GlobalCollect messages to donationinterface_langonly.phpawjrichards02:17, 31 October 2011
r101553Updated form validation for module.jpostlethwaite23:53, 1 November 2011
r101557Updated GlobalCollect Adapter to include Direct Debit.jpostlethwaite00:03, 2 November 2011
r101561Updated form to handle Direct Debit.jpostlethwaite00:15, 2 November 2011
r101785Lots going on here, in preparation for re-designing the way we validate and a...khorn04:15, 3 November 2011
r101823Added helper methods: getTransactionDataFormAction() and getTransactionDataLa...jpostlethwaite15:44, 3 November 2011
r101826Changed displayResultsForDebug() to not require the $results parameter. This ...jpostlethwaite15:51, 3 November 2011
r101837Fixes up the new addData function in the adapter, to handle things like re-ca...khorn17:39, 3 November 2011
r101870Updated validation to properly handle radio buttons.jpostlethwaite20:20, 3 November 2011
r101871Added comment as to why validation of the state field is ignored.jpostlethwaite20:24, 3 November 2011
r101872Added red color for error messages.jpostlethwaite20:25, 3 November 2011
r101882Added getFormMessagesByType(), getBankTransfer() and getRealTimeBankTransfer().jpostlethwaite21:07, 3 November 2011
r101890making canadian provinces translatablekaldari21:58, 3 November 2011
r101910adding new currencies for sanity check, correcting 2 currency codes, follow-u...kaldari23:06, 3 November 2011
r101947adding separate currency support for different gateways, adding support for p...kaldari02:10, 4 November 2011
r101949Adds another custom filter: One that is based on calling functions back in th...khorn03:02, 4 November 2011
r101950adding french province nameskaldari03:07, 4 November 2011
r101951Adds to GlobalCollect, two new transactions that are meant to fire as the res...khorn03:10, 4 November 2011
r101955Added resultHandler() and resultHandlerError().jpostlethwaite05:14, 4 November 2011
r101956Added $error_map, getErrorMap(), getErrorMapByCodeAndTranslate(), getTransact...jpostlethwaite05:18, 4 November 2011
r101957Added defineErrorMap().jpostlethwaite05:19, 4 November 2011
r101958Added getGoToThankYouOn(). This is a lookup to see which statuses are accepte...jpostlethwaite05:30, 4 November 2011
r101959Added defineErrorMap(), Added new code range. Added defineGoToThankYouOn(). U...jpostlethwaite05:36, 4 November 2011
r101960Removing usage of $result and $data from the view. Enabling bank transfer, re...jpostlethwaite05:41, 4 November 2011
r101964Fixed wrong variable being used for form messages.jpostlethwaite06:57, 4 November 2011
r101965$return variable is only used once. No need to append.jpostlethwaite06:58, 4 November 2011
r101966Fixed wrong variable being used for return.jpostlethwaite06:59, 4 November 2011
r102030Locks down all staged gateway data, and (hopefully) makes the distinction bet...khorn19:37, 4 November 2011
r102032Added more entries for $this->var_map for bank transferjpostlethwaite19:41, 4 November 2011
r102033Added display helper for GlobalCollect bank transfer.jpostlethwaite19:42, 4 November 2011
r102047Establishes constraints on settable fields that should contain the over-archi...khorn21:09, 4 November 2011
r102050Added helpers: getPaymentMethod() and getPaymentSubmethod().jpostlethwaite21:36, 4 November 2011
r102051Added helper: getPaymentSubmethodFormValidation().jpostlethwaite21:37, 4 November 2011
r102052Removing dependency from accessing raw data in GlobalCollectGateway::execute(...jpostlethwaite21:40, 4 November 2011
r102054Added payment_method and payment_submethod as arguments for the Thank you pag...jpostlethwaite21:45, 4 November 2011
r102056Removing AMEX from GC webitects until further noticepgehres22:04, 4 November 2011
r102058Also removing Discover from GC webitects until further noticepgehres22:08, 4 November 2011
r102065an important message from our sponsorskaldari22:51, 4 November 2011
r102081Finishes up the first pass on the new scheme we need to use, for confirming a...khorn01:47, 5 November 2011
r102085Changed public methods to protected.jpostlethwaite04:39, 5 November 2011
r102086Added method: addKeyToTransaction(). This is a helper to modify the transacti...jpostlethwaite04:41, 5 November 2011
r102087Added new information to payment_submethods. Required keys are now designated...jpostlethwaite05:15, 5 November 2011
r102118Localisation updates for core and extension messages from translatewiki.netraymond21:03, 5 November 2011
r102120Fixed Sweden spelling mistake see r100823.jpostlethwaite21:08, 5 November 2011
r102124Added state field to form.jpostlethwaite22:13, 5 November 2011
r102125Requiring state, country and zip on all forms. See r101556.jpostlethwaite22:32, 5 November 2011
r102127changing please enter a state errors to please enter a state/province by adju...jamesur23:04, 5 November 2011
r102134Adds the ability to log out out communication stats, through the regular logg...khorn00:41, 6 November 2011
r102140Prevents anything that isn't a credit card transaction from abusing the Globa...khorn02:00, 6 November 2011
r102147Adding back incorrectly removed cc types for pfp-CApgehres03:11, 6 November 2011
r102151Moved the method addKeyToTransaction() out of parent class. The logic was gat...jpostlethwaite04:15, 6 November 2011
r102152Adding BT form for GlobalCollect. Refactored JS to allow for common include ...pgehres04:21, 6 November 2011
r102155Adding country specific BT forms for US and CA, removing state field from non...pgehres05:12, 6 November 2011
r102156add extra ideal bank and adjust name for SNS Regiojamesur05:26, 6 November 2011
r102186Adds the original transaction response status to the set_payment response, ju...khorn19:55, 6 November 2011
r102188adding currency minimums to webitects js validationkaldari20:01, 6 November 2011

Status & tagging log