r100671 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r100670‎ | r100671 | r100672 >
Date:00:34, 25 October 2011
Author:jpostlethwaite
Status:ok (Comments)
Tags:fundraising 
Comment:
Simplified validation arrays for payments.
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php
——@@ -240,7 +240,7 @@
241241 'paymentproductid' => 1,
242242 'label' => 'Visa',
243243 'group' => 'cc',
244 - 'validation' => array( 'address' => true, 'amount' => true, 'email' => true, 'name' => true, ),
 244+ 'validation' => array(),
245245 );
246246
247247 // MasterCard
——@@ -248,7 +248,7 @@
249249 'paymentproductid' => 3,
250250 'label' => 'MasterCard',
251251 'group' => 'cc',
252 - 'validation' => array( 'address' => true, 'amount' => true, 'email' => true, 'name' => true, ),
 252+ 'validation' => array(),
253253 );
254254
255255 // American Express
——@@ -256,7 +256,7 @@
257257 'paymentproductid' => 2,
258258 'label' => 'American Express',
259259 'group' => 'cc',
260 - 'validation' => array( 'address' => true, 'amount' => true, 'email' => true, 'name' => true, ),
 260+ 'validation' => array(),
261261 );
262262
263263 // Maestro
——@@ -264,7 +264,7 @@
265265 'paymentproductid' => 117,
266266 'label' => 'Maestro',
267267 'group' => 'cc',
268 - 'validation' => array( 'address' => true, 'amount' => true, 'creditCard' => true, 'email' => true, 'name' => true, ),
 268+ 'validation' => array(),
269269 );
270270
271271 // Solo
——@@ -272,7 +272,7 @@
273273 'paymentproductid' => 118,
274274 'label' => 'Solo',
275275 'group' => 'cc',
276 - 'validation' => array( 'address' => true, 'amount' => true, 'creditCard' => true, 'email' => true, 'name' => true, ),
 276+ 'validation' => array(),
277277 );
278278
279279 // Laser
——@@ -280,7 +280,7 @@
281281 'paymentproductid' => 124,
282282 'label' => 'Laser',
283283 'group' => 'cc',
284 - 'validation' => array( 'address' => true, 'amount' => true, 'creditCard' => true, 'email' => true, 'name' => true, ),
 284+ 'validation' => array(),
285285 );
286286
287287 // JCB
——@@ -288,7 +288,7 @@
289289 'paymentproductid' => 125,
290290 'label' => 'JCB',
291291 'group' => 'cc',
292 - 'validation' => array( 'address' => true, 'amount' => true, 'creditCard' => true, 'email' => true, 'name' => true, ),
 292+ 'validation' => array(),
293293 );
294294
295295 // Discover
——@@ -296,7 +296,7 @@
297297 'paymentproductid' => 128,
298298 'label' => 'Discover',
299299 'group' => 'cc',
300 - 'validation' => array( 'address' => true, 'amount' => true, 'creditCard' => true, 'email' => true, 'name' => true, ),
 300+ 'validation' => array(),
301301 );
302302
303303 // CB
——@@ -304,7 +304,7 @@
305305 'paymentproductid' => 130,
306306 'label' => 'CB', // Carte Bancaire OR Carte Bleue
307307 'group' => 'cc',
308 - 'validation' => array( 'address' => true, 'amount' => true, 'creditCard' => true, 'email' => true, 'name' => true, ),
 308+ 'validation' => array(),
309309 );
310310
311311 /*
——@@ -316,7 +316,7 @@
317317 'paymentproductid' => 11,
318318 'label' => 'Bank Transfer',
319319 'group' => 'bt',
320 - 'validation' => array( 'creditCard' => false, ),
 320+ 'validation' => array(),
321321 );
322322
323323 /*
——@@ -328,7 +328,7 @@
329329 'paymentproductid' => 805,
330330 'label' => 'Nordea (Sweeden)',
331331 'group' => 'rtbt',
332 - 'validation' => array( 'creditCard' => false, ),
 332+ 'validation' => array(),
333333 );
334334
335335 // Ideal
——@@ -336,7 +336,7 @@
337337 'paymentproductid' => 809,
338338 'label' => 'Ideal',
339339 'group' => 'rtbt',
340 - 'validation' => array( 'creditCard' => false, ),
 340+ 'validation' => array(),
341341 'issuerids' => array(
342342 771 => 'RegioBank',
343343 161 => 'Van Lanschot Bankiers',
——@@ -355,7 +355,7 @@
356356 'paymentproductid' => 810,
357357 'label' => 'eNETS',
358358 'group' => 'rtbt',
359 - 'validation' => array( 'creditCard' => false, ),
 359+ 'validation' => array(),
360360 );
361361
362362 // Sofortuberweisung/DIRECTebanking
——@@ -363,7 +363,7 @@
364364 'paymentproductid' => 836,
365365 'label' => 'Sofortuberweisung/DIRECTebanking',
366366 'group' => 'rtbt',
367 - 'validation' => array( 'creditCard' => false, ),
 367+ 'validation' => array(),
368368 );
369369
370370 // eps Online-Überweisung
——@@ -371,7 +371,7 @@
372372 'paymentproductid' => 856,
373373 'label' => 'eps Online-Überweisung',
374374 'group' => 'rtbt',
375 - 'validation' => array( 'creditCard' => false, ),
 375+ 'validation' => array(),
376376 'issuerids' => array(
377377 824 => 'Bankhaus Spängler',
378378 825 => 'Hypo Tirol Bank',

Follow-up revisions

RevisionCommit summaryAuthorDate
r102236MFT r90286, r100671, r100837, r100950, r101060, r101063, r101064, r101073, r1......khorn03:06, 7 November 2011
r102237MFT r90286, r100671, r100837, r100950, r101060, r101063, r101064, r101073, r1......khorn03:07, 7 November 2011

Comments

#Comment by Khorn (WMF) (talk | contribs)   19:01, 27 October 2011

I like where this is going. :)

Status & tagging log