r90257 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90256‎ | r90257 | r90258 >
Date:03:56, 17 June 2011
Author:bawolff
Status:ok
Tags:
Comment:
revert r87808 - Its broken, and looks rather complex to fix, especially with namespace aliases.

See comments on r87808 for details.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/specials/SpecialMovepage.php (modified) (history)
  • /trunk/phase3/resources/mediawiki.special/mediawiki.special.movePage.js (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -61,7 +61,6 @@
6262 used in Tiff files.
6363 * When translcuding a special page, do not let it interpret url parameters.
6464 * (bug 28887) Special page classes are no longer re-used during 1 request.
65 -* New title field of Special:MovePage is now length limited on client side.
6665 * (bug 28888) Searching for something starting with a # sign no longer tells
6766 the user a page named [[:]] already exists.
6867 * (bug 23002) Imagelinks table not updated after imagemove.
Index: trunk/phase3/includes/specials/SpecialMovepage.php
@@ -229,8 +229,7 @@
230230 Xml::label( wfMsg( 'newtitle' ), 'wpNewTitle' ) .
231231 "</td>
232232 <td class='mw-input'>" .
233 - Xml::input( 'wpNewTitle', 40, $wgContLang->recodeForEdit( $newTitle->getPrefixedText() ), array( 'type' => 'text', 'id' => 'wpNewTitle', 'maxlength' => 255 ) ) .
234 - // maxLength enforced in JS.
 233+ Xml::input( 'wpNewTitle', 40, $wgContLang->recodeForEdit( $newTitle->getPrefixedText() ), array( 'type' => 'text', 'id' => 'wpNewTitle' ) ) .
235234 Html::hidden( 'wpOldTitle', $this->oldTitle->getPrefixedText() ) .
236235 "</td>
237236 </tr>
Index: trunk/phase3/resources/mediawiki.special/mediawiki.special.movePage.js
@@ -2,5 +2,4 @@
33
44 jQuery( function( $ ) {
55 $( '#wpReason' ).byteLimit();
6 - $( '#wpNewTitle' ).byteLimit();
76 });

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87808Prevent user from trying to move a page to a title longer than 255 bytes....bawolff05:36, 10 May 2011

Status & tagging log