r89835 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89834‎ | r89835 | r89836 >
Date:17:09, 10 June 2011
Author:krinkle
Status:resolved
Tags:
Comment:
[Installer] .mw-help-hint and #config-live-log
* Merged padding rules into one
* Fixed the width issues of the textarea (see also r87975)
Modified paths:
  • /trunk/phase3/skins/common/config.css (modified) (history)
  • /trunk/phase3/skins/common/config.js (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/config.js
@@ -29,7 +29,7 @@
3030 } );
3131
3232 // Scroll to the bottom of upgrade log
33 - $( "#config-live-log" ).each( function() { this.scrollTop = this.scrollHeight; } );
 33+ $( '#config-live-log' ).find( '> textarea' ).each( function() { this.scrollTop = this.scrollHeight; } );
3434
3535 // Show/hide Creative Commons thingy
3636 $( '.licenseRadio' ).click( function() {
Index: trunk/phase3/skins/common/config.css
@@ -142,5 +142,5 @@
143143 }
144144
145145 #config-live-log {
146 - width: 70%;
 146+ margin-right: 18em;
147147 }
Index: trunk/phase3/skins/common/shared.css
@@ -643,18 +643,17 @@
644644 /* tooltip styles */
645645 .mw-help-field-hint {
646646 display: none;
647 - padding: 0px;
648 - padding-left: 15px;
649647 margin-left: 2px;
650648 margin-bottom: -8px;
 649+ padding: 0px 0px 0px 15px;
651650 /* @embed */
652651 background-image: url('images/help-question.gif');
653652 background-position: left center;
654653 background-repeat: no-repeat;
655 - color: #0645ad;
656 - text-decoration: underline;
657654 cursor: pointer;
658655 font-size: .8em;
 656+ text-decoration: underline;
 657+ color: #0645ad;
659658 }
660659 .mw-help-field-hint:hover {
661660 /* @embed */

Follow-up revisions

RevisionCommit summaryAuthorDate
r89849Follow-up r89835: Accidently comitted from a deeper dir than the diff. Comitt...krinkle20:16, 10 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87975Fix width of live log in installer, so that it floats correctly to the rightdiebuche13:21, 13 May 2011

Status & tagging log