r87975 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87974‎ | r87975 | r87976 >
Date:13:21, 13 May 2011
Author:diebuche
Status:ok (Comments)
Tags:
Comment:
Fix width of live log in installer, so that it floats correctly to the right
Modified paths:
  • /trunk/phase3/skins/common/config.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/config.css
@@ -160,5 +160,5 @@
161161 }
162162
163163 #config-live-log {
164 - width: 75%;
 164+ width: 70%;
165165 }
\ No newline at end of file

Follow-up revisions

RevisionCommit summaryAuthorDate
r89835[Installer] .mw-help-hint and #config-live-log...krinkle17:09, 10 June 2011

Comments

#Comment by Krinkle (talk | contribs)   17:10, 10 June 2011

#config-live-log isn't floated. How does this fix anything ? From what I can see it moves the issue.

The problem is that the sidebar (#config-page-list) has a width of 12em (18em including the padding margin) and the page content itself has a fluid width, so no matter what percentage it is set to it will always misalign with the rest of the paragraphs, and there will always be a case where it jumps below the sidebar if it's too wide.

compare:

I think neither is better or worse, they're all misaligned. The results may vary from browser to browser, though. But sadly it's implossible for a {[tag|textarea|open}} to get the same width as the paragraphs or the infobox (next to the sidebar). Reason being that those can have an auto width and/or overflow:hidden to get the proper size, where a textarea can't.

It's not hopeless though, it can be fixed by removing the width all together (letting it fallback to width:100%) and wrap the ‎<textarea> in a ‎<div> that can be adapted to the context. Done in r89835.

#Comment by Krinkle (talk | contribs)   17:11, 10 June 2011

Status & tagging log