r88502 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r88501‎ | r88502 | r88503 >
Date:00:02, 21 May 2011
Author:mah
Status:reverted (Comments)
Tags:
Comment:
Trial commit to fix bug #29043: “The 'Contents box' in the "Printable version" rendering is stupid”

Other people should try my patch and see if they agree that printing the
contents box on paper is stupid. Just commenting on the bug with your
opinion would be helpful.
Modified paths:
  • /trunk/phase3/skins/common/commonPrint.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/commonPrint.css
——@@ -14,9 +14,7 @@
1515 }
1616
1717 #toc {
18 - border: 1px solid #aaaaaa;
19 - background-color: #f9f9f9;
20 - padding: 5px;
 18+ display: none;
2119 }
2220 .tocindent {
2321 margin-left: 2em;

Follow-up revisions

RevisionCommit summaryAuthorDate
r88504r88502 tabs, not spaces.mah00:15, 21 May 2011
r89346Revert r88502 since this can be done with a gadgetmah16:02, 2 June 2011

Comments

#Comment by Jack Phoenix (talk | contribs)   00:03, 21 May 2011

It should be indented with one tab character instead of three spaces.

#Comment by MarkAHershberger (talk | contribs)   00:14, 21 May 2011

gah! thanks for noticing.

/me grumbles about mw coding conventions.

#Comment by Fomafix (talk | contribs)   06:49, 30 May 2011

I think the table of contents on paper is not stupid, it is often useful.

If you don't want to print the table of contents then klick on [hide] and the whole box with the table of contents gets hidden in the print version.

#Comment by MarkAHershberger (talk | contribs)   16:12, 30 May 2011

If that is all that is needed, then it seems like this would be better in a gadget that add's a "print w/o contents" link or something.

#Comment by Fomafix (talk | contribs)   08:15, 2 June 2011

This gadget already exists. See bug 482. But this feature doesn't work anymore since porting to ResourceLoader in r78941. In r78941 the JavaScript part to add and remove the css class tochidden is lost. tochidden is still in commonPrint.css. Here is a patch as a follow-up to r78941 to reactivate tochidden. Please revert r88502 and integrate the patch.

Status & tagging log