r89297 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89296‎ | r89297 | r89298 >
Date:22:04, 1 June 2011
Author:platonides
Status:reverted (Comments)
Tags:
Comment:
Not silly, but parser error (r89263)... fixing
PHP Parse error: syntax error, unexpected T_STRING, expecting T_VARIABLE in ExtensionUpdater.php on line 7
Modified paths:
  • /trunk/phase3/includes/installer/ExtensionUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/ExtensionUpdater.php
——@@ -4,7 +4,7 @@
55
66 // overload the constructor, so the init and hooks don't get called
77 // while still have all the patching code without duplicating
8 - public __construct( DatabaseBase &$db, $shared, Maintenance $maintenance = null ) {
 8+ public function __construct( DatabaseBase &$db, $shared, Maintenance $maintenance = null ) {
99 $this->db = $db;
1010 $this->shared = $shared;
1111 $this->maintenance = $maintenance;

Follow-up revisions

RevisionCommit summaryAuthorDate
r89586Revert r89263, r89297, r89347: unclear whether this is needed; DatabaseUpdate...brion18:35, 6 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89263* suggestion for ExtensionUpdater that would handle DB install/update of exte...freakolowsky15:15, 1 June 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   18:36, 6 June 2011

Reverted for now in r89586 along with parent r89263.

Status & tagging log