r89224 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89223‎ | r89224 | r89225 >
Date:20:23, 31 May 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Followup r87584, r87963

Why not fix both?
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -216,7 +216,7 @@
217217 <!-- panel -->
218218 <div id="mw-panel" class="noprint">
219219 <!-- logo -->
220 - <div id="p-logo"><a style="background-image: url(<?php $this->text( 'logopath' ) ?>);" href="<?php echo htmlspecialchars( $this->data['nav_urls']['mainpage']['href'] ) ?>" <?php echo Linker::tooltipAndAccesskeyAttribs( 'p-logo' ) ?>></a></div>
 220+ <div id="p-logo"><a style="background-image: url(<?php $this->text( 'logopath' ) ?>);" href="<?php echo htmlspecialchars( $this->data['nav_urls']['mainpage']['href'] ) ?>" <?php echo Xml::expandAttributes( Linker::tooltipAndAccesskeyAttribs( 'p-logo' ) ) ?>></a></div>
221221 <!-- /logo -->
222222 <?php $this->renderPortals( $this->data['sidebar'] ); ?>
223223 </div>

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87584More versions added to @deprecated tags...reedy21:50, 6 May 2011
r87963Re-do r87961 in a better way. Like I said, it's not acting the same as Linker...krinkle10:34, 13 May 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   20:36, 31 May 2011

Confirmed this fixes bug 29204 for me.

Status & tagging log