r87963 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r87962‎ | r87963 | r87964 >
Date:10:34, 13 May 2011
Author:krinkle
Status:ok
Tags:
Comment:
Re-do r87961 in a better way. Like I said, it's not acting the same as Linker::tooltip, which is already expended. Calling it when generating the HTML will try to expend the output from Linker::tooltip, which failed. Instead expending it where it's not normalized yet.
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
——@@ -111,7 +111,7 @@
112112 Linker::tooltip( $xmlID );
113113 } else {
114114 $nav[$section][$key]['key'] =
115 - Linker::tooltipAndAccesskeyAttribs( $xmlID );
 115+ Xml::expandAttributes( Linker::tooltipAndAccesskeyAttribs( $xmlID ) );
116116 }
117117 }
118118 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r89224Followup r87584, r87963...reedy20:23, 31 May 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87584More versions added to @deprecated tags...reedy21:50, 6 May 2011
r87961Fixing broken tooltip/accesskey's for view_urls in Vector. Thanks JeroenDeDau...krinkle10:26, 13 May 2011

Status & tagging log