r88740 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88739‎ | r88740 | r88741 >
Date:19:51, 24 May 2011
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
* Enumerate the specific templates/files that changed on review diffs
* Made diffonly=0 links diffonly=1 to avoid slow preview
* Reverted revreview-update-includes-p msg addition, bah
* Hide revreview-update-use notice for now...slightly misleading clutter
* Renamed $revIdStable -> $revIdUsed; var name was confusing
Modified paths:
  • /trunk/extensions/FlaggedRevs/business/RevisionReviewForm.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/dataclasses/FlaggedRevision.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/presentation/FlaggedPageView.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/presentation/language/FlaggedRevs.i18n.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/presentation/language/RevisionReview.i18n.php (modified) (history)

Diff [purge]

The diff is too large to display.

Follow-up revisions

RevisionCommit summaryAuthorDate
r88741Follow-up r88740: forgot to commit this guyaaron19:52, 24 May 2011
r88742Follow-up r88740: more "diffonly=0" => "diffonly=1"aaron20:04, 24 May 2011
r88780* Follow-up r88740:...aaron10:11, 25 May 2011
r88821* Follow-up r88740:...aaron19:38, 25 May 2011
r89131diffonly update for ProblemChangesaaron19:42, 29 May 2011
r96998Removed parser hacks from r88740, r88741, r88780aaron20:26, 13 September 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   21:15, 24 May 2011

There's a comment "Disable slow crap that doesn't matter for getting templates/files..." before a hack that appears to disable the 'ref' and 'references' tag hooks. Does this mean that templates used within a <nowiki><ref><nowiki> won't get recorded?

#Comment by Aaron Schulz (talk | contribs)   23:20, 24 May 2011

They don't get recorded with or without the hack in that case.

#Comment by Brion VIBBER (talk | contribs)   23:44, 24 May 2011

We sorted this out on IRC -- I meant "<ref>" referring to ref contents generally, ended up with a stray tag there. :)

With the hack behavior, it'll basically render the contents of the ref tags as simply inline wikitext that happens to be surrounded with some other text bits. This should expand everything needed well enough for these purposes, and apparently is much faster on some pages.

Will need to investigate those performance characteristics, but it looks fine here for now. Yay!

#Comment by Aaron Schulz (talk | contribs)   00:24, 13 September 2011

Tagged fixme until parser hacks reverted.

Status & tagging log