r96998 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96997‎ | r96998 | r96999 >
Date:20:26, 13 September 2011
Author:aaron
Status:ok
Tags:
Comment:
Removed parser hacks from r88740, r88741, r88780
Modified paths:
  • /trunk/extensions/FlaggedRevs/dataclasses/FRInclusionCache.php (modified) (history)
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -4702,19 +4702,6 @@
47034703 }
47044704
47054705 /**
4706 - * Remove a specific tag hook. Should not be called on $wgParser.
4707 - * Does not change the strip list.
4708 - *
4709 - * @param string $tag
4710 - * @return void
4711 - */
4712 - function clearTagHook( $tag ) {
4713 - if ( isset( $this->mTagHooks[$tag] ) ) {
4714 - unset( $this->mTagHooks[$tag] );
4715 - }
4716 - }
4717 -
4718 - /**
47194706 * Create a function, e.g. {{sum:1|2|3}}
47204707 * The callback function should have the form:
47214708 * function myParserFunction( &$parser, $arg1, $arg2, $arg3 ) { ... }
Index: trunk/extensions/FlaggedRevs/dataclasses/FRInclusionCache.php
@@ -39,11 +39,7 @@
4040 if ( $pOut == false || !FlaggedRevs::parserOutputIsVersioned( $pOut ) ) {
4141 $title = $article->getTitle();
4242 $pOpts = ParserOptions::newFromUser( $user ); // Note: tidy off
43 - # Disable slow crap that doesn't matter for getting templates/files...
44 - $parser = clone $wgParser;
45 - $parser->clearTagHook( 'ref' );
46 - $parser->clearTagHook( 'references' );
47 - $pOut = $parser->parse(
 43+ $pOut = $wgParser->parse(
4844 $rev->getText(), $title, $pOpts, true, true, $rev->getId() );
4945 }
5046 # Get the template/file versions used...

Follow-up revisions

RevisionCommit summaryAuthorDate
r97274REL1_18 MFT r96825, r96833, r96998reedy14:24, 16 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88740* Enumerate the specific templates/files that changed on review diffs...aaron19:51, 24 May 2011
r88741Follow-up r88740: forgot to commit this guyaaron19:52, 24 May 2011
r88780* Follow-up r88740:...aaron10:11, 25 May 2011

Status & tagging log