r88742 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88741‎ | r88742 | r88743 >
Date:20:04, 24 May 2011
Author:aaron
Status:ok
Tags:
Comment:
Follow-up r88740: more "diffonly=0" => "diffonly=1"
Modified paths:
  • /trunk/extensions/FlaggedRevs/presentation/FlaggedPageView.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/presentation/FlaggedRevsLogView.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/presentation/specialpages/reports/PendingChanges_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/presentation/specialpages/reports/PendingChanges_body.php
@@ -220,7 +220,7 @@
221221 $review = $this->skin->linkKnown( $title,
222222 wfMsg( 'pendingchanges-diff' ),
223223 array(),
224 - 'diff=cur&oldid='.intval($row->stable).'&diffonly=0' );
 224+ 'diff=cur&oldid='.intval($row->stable).'&diffonly=1' );
225225 # Show quality level if there are several
226226 if ( FlaggedRevs::qualityVersions() ) {
227227 $quality = $row->quality
Index: trunk/extensions/FlaggedRevs/presentation/FlaggedPageView.php
@@ -1488,7 +1488,7 @@
14891489 $review = $wgUser->getSkin()->makeKnownLinkObj(
14901490 $article->getTitle(),
14911491 wfMsgHtml( 'review-diff2stable' ),
1492 - 'oldid=' . $srev->getRevId() . '&diff=cur&diffonly=0'
 1492+ 'oldid=' . $srev->getRevId() . '&diff=cur&diffonly=1'
14931493 );
14941494 $review = wfMsgHtml( 'parentheses', $review );
14951495 $review = "<div class='fr-diff-to-stable' align='center'>$review</div>";
@@ -1649,7 +1649,7 @@
16501650 if ( $frev->userCanSetFlags( $wgUser ) ) {
16511651 $extraQuery .= $extraQuery ? '&' : '';
16521652 // Override diffonly setting to make sure the content is shown
1653 - $extraQuery .= 'oldid=' . $frev->getRevId() . '&diff=cur&diffonly=0&shownotice=1';
 1653+ $extraQuery .= 'oldid=' . $frev->getRevId() . '&diff=cur&diffonly=1&shownotice=1';
16541654 // ...otherwise, go to the draft revision after completing an edit.
16551655 // This allows for users to immediately see their changes.
16561656 } else {
Index: trunk/extensions/FlaggedRevs/presentation/FlaggedRevsLogView.php
@@ -126,7 +126,7 @@
127127 $links .= $wgUser->getSkin()->makeKnownLinkObj(
128128 $title,
129129 wfMsgHtml( 'review-logentry-id', $revId, $time ),
130 - "oldid={$revId}&diff=prev&diffonly=0"
 130+ "oldid={$revId}&diff=prev&diffonly=1"
131131 );
132132 $links .= ')';
133133 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88740* Enumerate the specific templates/files that changed on review diffs...aaron19:51, 24 May 2011

Status & tagging log