r88551 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88550‎ | r88551 | r88552 >
Date:22:44, 21 May 2011
Author:reedy
Status:ok
Tags:
Comment:
* (bug 26240) CodeReview's (partially absence of) query params suck (tracking)

Make filtering by author/status work for each other when using the main list view

$suckage--;
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -24,6 +24,7 @@
2525 }
2626
2727 $this->mAuthor = $wgRequest->getText( 'author' );
 28+ $this->mStatus = $wgRequest->getText( 'status' );
2829 $this->mAppliedFilter = null;
2930 }
3031
@@ -348,14 +349,22 @@
349350 $pathQuery
350351 );
351352 case 'cr_status':
 353+ $options = $pathQuery;
 354+ if ( $this->mView->mAuthor ) {
 355+ $options['author'] = $this->mView->mAuthor;
 356+ }
352357 return $this->mView->skin->link(
353358 SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() . '/status/' . $value ),
354359 htmlspecialchars( $this->mView->statusDesc( $value ) ),
355360 array(),
356 - $pathQuery
 361+ $options
357362 );
358363 case 'cr_author':
359 - return $this->mView->authorLink( $value, $pathQuery );
 364+ $options = $pathQuery;
 365+ if ( $this->mView->mStatus ) {
 366+ $options['status'] = $this->mView->mStatus;
 367+ }
 368+ return $this->mView->authorLink( $value, $options );
360369 case 'cr_message':
361370 return $this->mView->messageFragment( $value );
362371 case 'cr_timestamp':

Follow-up revisions

RevisionCommit summaryAuthorDate
r88552Followup r88551, add some more filtering parameters to be usedreedy22:47, 21 May 2011
r88556* (bug 26240) CodeReview's (partially absence of) query params suck (tracking)...reedy23:34, 21 May 2011

Status & tagging log